Re: git-diff-tree -z HEAD | git-diff-helper -z fails for me

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: git-diff-tree -z HEAD | git-diff-helper -z fails for me

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:41:58

quoted
quoted
quoted
quoted
"Tg" == Thomas Glanzmann [off-list ref] writes:
Tg> Hello,
Tg> this fails:

Tg> 	(faui00u) [~/work/git/yagf] git-diff-tree -z HEAD | git-diff-helper -z
Tg> 	03c70739ae572ea9832b97dfcf9ca2594702efe8 (from 30e756ea8569bb429b7073b304acd8a960f77e4b)
Tg> 	:100755 100755 f2e04c3b45b2a5ab5cf53228025158902c9de5be b93fd0310e51eea4d48d42c6ad83399cff8ab56egitgit(faui00u) [~/work/git/yagf]

Tg> What I am doing wrong here?

Nothing.  I'm an idiot.

Linus, do you mind if I say with "-z" git-diff-tree should not
do _any_ header thing?

Re: git-diff-tree -z HEAD | git-diff-helper -z fails for me

From: Linus Torvalds <torvalds@osdl.org>
Date: 2016-06-15 22:41:58


On Mon, 23 May 2005, Junio C Hamano wrote:
Tg> 	(faui00u) [~/work/git/yagf] git-diff-tree -z HEAD | git-diff-helper -z
Tg> 	03c70739ae572ea9832b97dfcf9ca2594702efe8 (from 30e756ea8569bb429b7073b304acd8a960f77e4b)
Tg> 	:100755 100755 f2e04c3b45b2a5ab5cf53228025158902c9de5be b93fd0310e51eea4d48d42c6ad83399cff8ab56egitgit(faui00u) [~/work/git/yagf]

Tg> What I am doing wrong here?

Nothing.  I'm an idiot.

Linus, do you mind if I say with "-z" git-diff-tree should not
do _any_ header thing?
How about instead making sure that any "extra" text be NUL-terminated and
never start with ':' after a NUL (which will automatically be true, since
it's either "diff-tree " + ascii for the verbose case, or just the tree
name).

That way git-diff-helper automatically does the right thing when it just 
passes lines (where "lines" is defined as being NUL-terminated) that it 
doesn't understand through unmodified.

		Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help