Re: [PATCH 3/3] - Convert git-checkout-cache to argp

2 messages, 2 authors, 2016-06-15 · open the first message on its own page

Re: [PATCH 3/3] - Convert git-checkout-cache to argp

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:41:58

quoted
quoted
quoted
quoted
"JG" == Jeff Garzik [off-list ref] writes:
JG> Sean wrote:
quoted
Use argp to process command line arguments for git-checkout-cache.  Also,
fix things up so that the order of options on the command line no longer
matters.  To this end, the "-f" (--force) switch only applies to the
individual files given on the command line.   A new forcing version of the
"-a" (--all) switch is added as "-A" (--forceall).
JG> I agree with Junio -- this patch breaks stuff.

Yes, and that is exactly why I wanted to see the documentation
changes first before the code.

Re: [PATCH 3/3] - Convert git-checkout-cache to argp

From: Sean <hidden>
Date: 2016-06-15 22:41:58

On Sat, May 21, 2005 5:24 pm, Junio C Hamano said:
quoted
quoted
quoted
quoted
quoted
"JG" == Jeff Garzik [off-list ref] writes:
JG> Sean wrote:
quoted
quoted
Use argp to process command line arguments for git-checkout-cache.
Also,
fix things up so that the order of options on the command line no
longer
matters.  To this end, the "-f" (--force) switch only applies to the
individual files given on the command line.   A new forcing version of
the
"-a" (--all) switch is added as "-A" (--forceall).
JG> I agree with Junio -- this patch breaks stuff.

Yes, and that is exactly why I wanted to see the documentation
changes first before the code.
Okay.  Attached no longer tries to maintain the feature of unforced -a in
combination with forced file list.  So:


Use argp to process command line arguments for git-checkout-cache.  Also,
fix things up so that the order of options on the command line no longer
matters.  To this end, the "-f" (--force) option always affects the -a
(--all) option no matter where it appears on the command line.

Signed-off-by: Sean Estabrooks <redacted>


 Documentation/git-checkout-cache.txt |   16 ++--
 checkout-cache.c                     |  120
++++++++++++++++-------------------
 2 files changed, 64 insertions(+), 72 deletions(-)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help