[PATCH Cogito] Improve option parsing for cg-log

Hi Petr,

the attached patch changes the option parsing, because otherwise we are
stuck to a specific order.

Regards

Marcel


Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Dear diary, on Thu, May 12, 2005 at 10:51:54PM CEST, I got a letter
where Marcel Holtmann [off-list ref] told me that...

Hi Petr,

Hi,

the attached patch changes the option parsing, because otherwise we are
stuck to a specific order.

thanks, applied. However, you didn't include the -r options parsing in
there yet.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor

Hi Petr,

quoted

the attached patch changes the option parsing, because otherwise we are
stuck to a specific order.

thanks, applied. However, you didn't include the -r options parsing in
there yet.

what do you mean by that?

Regards

Marcel

Dear diary, on Thu, May 12, 2005 at 11:49:46PM CEST, I got a letter
where Marcel Holtmann [off-list ref] told me that...

Hi Petr,

quoted

quoted

the attached patch changes the option parsing, because otherwise we are
stuck to a specific order.

thanks, applied. However, you didn't include the -r options parsing in
there yet.

what do you mean by that?

The -r option still must be after all the other options.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor

Hi Petr,

quoted

quoted

quoted

the attached patch changes the option parsing, because otherwise we are
stuck to a specific order.

thanks, applied. However, you didn't include the -r options parsing in
there yet.

what do you mean by that?

The -r option still must be after all the other options.

I see what you mean and it seems that I missed that option. Must be
because you put the list_commit_files() between them and I assumed that
there is no further option parsing.

Do you really wanna keep the double meaning of -r. Depending on a
previous -r it is $log_start or $log_end.

Regards

Marcel

Petr Baudis wrote:

The -r option still must be after all the other options.

I've been thinking about option parsing as well, and I think cogito 
could use a more "getopt-like" handling of options. "cg-log -cf"
or "cg-diff -rorigin" is just so much easier to type...

The attached patch implements that for cg-log and cg-diff, by means of 
two new helper functions in cg-Xlib. It also improves error-handling a bit.

How about it?

/dan

Dear diary, on Fri, May 13, 2005 at 11:05:34AM CEST, I got a letter
where Marcel Holtmann [off-list ref] told me that...

Hi Petr,

Hi,

quoted

The -r option still must be after all the other options.

I see what you mean and it seems that I missed that option. Must be
because you put the list_commit_files() between them and I assumed that
there is no further option parsing.

Uhm, I know. :-) It sorta evolved like that. We didn't yet settle down
on where to actually put the functions. I'd say right after . cg-Xlib.

Do you really wanna keep the double meaning of -r. Depending on a
previous -r it is $log_start or $log_end.

Yes, by all means. On one side I like the colon notation, on the other
side this was always my biggest usability problem with SVN. And it costs
us nothing and does what the user would after all expect, I think.

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
C++: an octopus made by nailing extra legs onto a dog. -- Steve Taylor