DORMANTno replies

[PATCH] Really honor umask when creating files

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:41:52

The stated plan was to create new files with either 0666 or 0777
and let the system take care of applying umask().  Running
fchmod afterwards defeats this plan, so drop it.

You still need to spell your octals with prefix in addition to
this patch.

Signed-off-by: Junio C Hamano <redacted>
---

 checkout-cache.c |    2 --
 1 files changed, 2 deletions(-)

checkout-cache.c: a87022a97c4604ef42ae6c31d641dc749a076ca3
--- checkout-cache.c
+++ checkout-cache.c	2005-04-17 01:11:17.000000000 -0700
@@ -62,8 +62,6 @@
 			fd = open(path, O_WRONLY | O_TRUNC | O_CREAT, mode);
 		}
 	}
-	if (fd >= 0)
-		fchmod(fd, mode);
 	return fd;
 }
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help