[PATCH] dedupe_percentage should work even if compress_percentage is not set

STALE4278d

2 messages, 2 authors, 2015-01-28 · open the first message on its own page

[PATCH] dedupe_percentage should work even if compress_percentage is not set

From: Vasily Tarasov <hidden>
Date: 2015-01-27 19:24:38

[PATCH] dedupe_percentage should work even if compress_percentage is not set 

Currently dedupe_percentage option does not work properly if compress_percentage
is not set. This can be easily demonstrated using the following job file:

[job-/dev/dm-0]
filename=/dev/dm-0
rw=randwrite
blocksize=4096
direct=1
ioengine=libaio
iodepth=32
dedupe_percentage=50
time_based=1
runtime=5
numjobs=1

All writes will contain zeroes for the above job file.

The problem is in fill_io_buffer() function that switches dedupe random state
only if o->compress_percentage is set.                                                                                                                                                                         

This patch updates the condition appropriately in fill_io_buffer()
appropriately.

Signed-off-by: Vasily Tarasov <redacted>

Re: [PATCH] dedupe_percentage should work even if compress_percentage is not set

From: Jens Axboe <axboe@kernel.dk>
Date: 2015-01-28 16:11:51

On 01/27/2015 12:24 PM, Vasily Tarasov wrote:
[PATCH] dedupe_percentage should work even if compress_percentage is not set

Currently dedupe_percentage option does not work properly if compress_percentage
is not set. This can be easily demonstrated using the following job file:

[job-/dev/dm-0]
filename=/dev/dm-0
rw=randwrite
blocksize=4096
direct=1
ioengine=libaio
iodepth=32
dedupe_percentage=50
time_based=1
runtime=5
numjobs=1

All writes will contain zeroes for the above job file.

The problem is in fill_io_buffer() function that switches dedupe random state
only if o->compress_percentage is set.

This patch updates the condition appropriately in fill_io_buffer()
appropriately.
Thanks, looks good, applied.

-- 
Jens Axboe

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help