Re: [PATCH v11 23/25] mm/gup: track FOLL_PIN pages

[PATCH v10 00/25] mm/gup: track dma-pinned pages: FOLL_PIN · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 13/25] mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote() · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 23/25] mm/gup: track FOLL_PIN pages · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
Re: [PATCH v10 23/25] mm/gup: track FOLL_PIN pages · Jan Kara <jack@suse.cz> · 2019-12-12
[PATCH v11 23/25] mm/gup: track FOLL_PIN pages · John Hubbard <jhubbard@nvidia.com> · 2019-12-14
Re: [PATCH v11 23/25] mm/gup: track FOLL_PIN pages · Jan Kara <jack@suse.cz> · 2019-12-16
Re: [PATCH v11 23/25] mm/gup: track FOLL_PIN pages · John Hubbard <jhubbard@nvidia.com> · 2019-12-16
Re: [PATCH v11 23/25] mm/gup: track FOLL_PIN pages · Jan Kara <jack@suse.cz> · 2019-12-17
[PATCH v10 09/25] IB/umem: use get_user_pages_fast() to pin DMA pages · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 25/25] selftests/vm: run_vmtests: invoke gup_benchmark with basic FOLL_PIN coverage · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 06/25] mm: fix get_user_pages_remote()'s handling of FOLL_LONGTERM · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 24/25] mm/gup_benchmark: support pin_user_pages() and related calls · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 07/25] vfio: fix FOLL_LONGTERM use, simplify get_user_pages_remote() call · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 22/25] mm, tree-wide: rename put_user_page*() to unpin_user_page*() · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 12/25] IB/{core,hw,umem}: set FOLL_PIN via pin_user_pages*(), fix up ODP · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 21/25] mm/gup_benchmark: use proper FOLL_WRITE flags instead of hard-coding "1" · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 04/25] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 10/25] mm/gup: introduce pin_user_pages*() and FOLL_PIN · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 03/25] mm: Cleanup __put_devmap_managed_page() vs ->page_free() · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 08/25] mm/gup: allow FOLL_FORCE for get_user_pages_fast() · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 11/25] goldish_pipe: convert to pin_user_pages() and put_user_page() · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 17/25] media/v4l2-core: set pages dirty upon releasing DMA buffers · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 19/25] vfio, mm: pin_user_pages (FOLL_PIN) and put_user_page() conversion · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 02/25] mm/gup: move try_get_compound_head() to top, fix minor issues · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 15/25] fs/io_uring: set FOLL_PIN via pin_user_pages() · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 18/25] media/v4l2-core: pin_user_pages (FOLL_PIN) and put_user_page() conversion · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 20/25] powerpc: book3s64: convert to pin_user_pages() and put_user_page() · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 01/25] mm/gup: factor out duplicate code from four routines · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 14/25] drm/via: set FOLL_PIN via pin_user_pages_fast() · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 16/25] net/xdp: set FOLL_PIN via pin_user_pages() · John Hubbard <jhubbard@nvidia.com> · 2019-12-12
[PATCH v10 05/25] goldish_pipe: rename local pin_user_pages() routine · John Hubbard <jhubbard@nvidia.com> · 2019-12-12

From: John Hubbard <jhubbard@nvidia.com>
Date: 2019-12-16 22:21:56
Also in: bpf, kvm, linux-block, linux-doc, linux-fsdevel, linux-kselftest, linux-media, linux-mm, linux-rdma, linuxppc-dev, lkml, netdev

On 12/16/19 4:53 AM, Jan Kara wrote:
...

I'd move this still a bit higher - just after VM_BUG_ON_PAGE() and before
if (flags & FOLL_TOUCH) test. Because touch_pmd() can update page tables
and we don't won't that if we're going to fail the fault.

Done. I'll post a full v11 series shortly.

With this fixed, the patch looks good to me so you can then add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

btw, thanks for the thorough review of this critical patch (and for your
patience with my mistakes). I really appreciate it, and this patchset would
not have made it this far without your detailed help and explanations.


thanks,
-- 
John Hubbard
NVIDIA
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help