Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic.
From: Arun Sudhilal <hidden>
Date: 2018-10-23 04:46:51
Also in:
amd-gfx, ceph-devel, dm-devel, intel-gfx, kexec, linux-fsdevel, linux-mediatek, linux-mm, linux-pm, linux-um, linuxppc-dev, netdev, netfilter-devel
Possibly related (same subject, not in this thread)
- 2018-11-22 · Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic. · "Kuehling, Felix" <Felix.Kuehling@amd.com>
- 2018-11-22 · Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic. · Guo Ren <hidden>
- 2018-10-23 · Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic. · Huang, Ying <hidden>
- 2018-10-23 · Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic. · Arun KS <hidden>
- 2018-10-23 · Re: [PATCH] mm: convert totalram_pages, totalhigh_pages and managed_pages to atomic. · Joe Perches <joe@perches.com>
On Mon, Oct 22, 2018 at 11:41 PM Michal Hocko [off-list ref] wrote:
On Mon 22-10-18 22:53:22, Arun KS wrote:quoted
Remove managed_page_count_lock spinlock and instead use atomic variables.
Hello Michal,
I assume this has been auto-generated. If yes, it would be better to mention the script so that people can review it and regenerate for comparision. Such a large change is hard to review manually.
Changes were made partially with script. For totalram_pages and
totalhigh_pages,
find dir -type f -exec sed -i
's/totalram_pages/atomic_long_read(\&totalram_pages)/g' {} \;
find dir -type f -exec sed -i
's/totalhigh_pages/atomic_long_read(\&totalhigh_pages)/g' {} \;
For managed_pages it was mostly manual edits after using,
find mm/ -type f -exec sed -i
's/zone->managed_pages/atomic_long_read(\&zone->managed_pages)/g' {}
\;
Regards,
Arun
-- Michal Hocko SUSE Labs