From: Ivan Malov <hidden> Date: 2025-07-11 14:44:00
The 25.07 release has got support for AMD Solarflare X45xx adapters [1].
This series is a follow-up to [1] to fix compiler warnings in the base
driver that are seen in Windows driver build, also based on this driver.
[1] https://patches.dpdk.org/project/dpdk/list/?series=35095
Ivan Malov (3):
common/sfc_efx/base: fix compiler warnings in statistic code
common/sfc_efx/base: fix compiler warnings in PHY link setup
common/sfc_efx/base: fix compiler warning in PHY link getter
drivers/common/sfc_efx/base/efx_np.c | 7 ++-----
drivers/common/sfc_efx/base/medford4_phy.c | 1 -
2 files changed, 2 insertions(+), 6 deletions(-)
--
2.39.5
From: Ivan Malov <hidden> Date: 2025-07-11 14:44:06
Fixes: f2f77453cb9f ("common/sfc_efx/base: fill in software LUT for MAC statistics")
Suggested-by: Andy Moreton <redacted>
Signed-off-by: Ivan Malov <redacted>
Reviewed-by: Andy Moreton <redacted>
---
drivers/common/sfc_efx/base/efx_np.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
From: Andrew Rybchenko <hidden> Date: 2025-07-26 11:51:28
On 7/11/25 17:43, Ivan Malov wrote:
quoted hunk
Fixes: f2f77453cb9f ("common/sfc_efx/base: fill in software LUT for MAC statistics")
Suggested-by: Andy Moreton <redacted>
Signed-off-by: Ivan Malov <redacted>
Reviewed-by: Andy Moreton <redacted>
---
drivers/common/sfc_efx/base/efx_np.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
IMHO it would be better to group similar fixes as unused variables into
single patch which clearly explains what's happening.
The goal is to "fix unused variable warnings".
The way is to "Remove unused variables."
From: Ivan Malov <hidden> Date: 2025-07-11 14:44:19
Fixes: 2a5cf77e6de8 ("common/sfc_efx/base: provide PHY link get method on Medford4")
Suggested-by: Andy Moreton <redacted>
Signed-off-by: Ivan Malov <redacted>
Reviewed-by: Andy Moreton <redacted>
---
drivers/common/sfc_efx/base/medford4_phy.c | 1 -
1 file changed, 1 deletion(-)
From: Stephen Hemminger <stephen@networkplumber.org> Date: 2025-07-11 14:55:51
On Fri, 11 Jul 2025 18:43:46 +0400
Ivan Malov [off-list ref] wrote:
The 25.07 release has got support for AMD Solarflare X45xx adapters [1].
This series is a follow-up to [1] to fix compiler warnings in the base
driver that are seen in Windows driver build, also based on this driver.
[1] https://patches.dpdk.org/project/dpdk/list/?series=35095
Ivan Malov (3):
common/sfc_efx/base: fix compiler warnings in statistic code
common/sfc_efx/base: fix compiler warnings in PHY link setup
common/sfc_efx/base: fix compiler warning in PHY link getter
drivers/common/sfc_efx/base/efx_np.c | 7 ++-----
drivers/common/sfc_efx/base/medford4_phy.c | 1 -
2 files changed, 2 insertions(+), 6 deletions(-)
Have your tried enabling -Wshadow and -Wduplicated-branches and -Wduplicated-cond
Those flags are finding stuff in other places.
From: Ivan Malov <hidden> Date: 2025-07-11 15:13:05
On Fri, 11 Jul 2025, Stephen Hemminger wrote:
On Fri, 11 Jul 2025 18:43:46 +0400
Ivan Malov [off-list ref] wrote:
quoted
The 25.07 release has got support for AMD Solarflare X45xx adapters [1].
This series is a follow-up to [1] to fix compiler warnings in the base
driver that are seen in Windows driver build, also based on this driver.
[1] https://patches.dpdk.org/project/dpdk/list/?series=35095
Ivan Malov (3):
common/sfc_efx/base: fix compiler warnings in statistic code
common/sfc_efx/base: fix compiler warnings in PHY link setup
common/sfc_efx/base: fix compiler warning in PHY link getter
drivers/common/sfc_efx/base/efx_np.c | 7 ++-----
drivers/common/sfc_efx/base/medford4_phy.c | 1 -
2 files changed, 2 insertions(+), 6 deletions(-)
Have your tried enabling -Wshadow and -Wduplicated-branches and -Wduplicated-cond
Those flags are finding stuff in other places.
Thanks Stephen. That is very useful. I tried adding these flags via meson.build
for common/sfc_efx, common/sfc_efx/base and for net/sfc trees and the only thing
I was able to find is as follows:
In file included from ../lib/eal/x86/include/rte_byteorder.h:9,
from ../drivers/net/sfc/sfc_ef10_essb_rx.c:14:
../drivers/net/sfc/sfc_ef10_essb_rx.c: In function ‘sfc_ef10_essb_rx_qsize_up_rings’:
../drivers/net/sfc/sfc_dp.h:27:27: warning: declaration of ‘_a’ shadows a previous local [-Wshadow]
27 | typeof(a) _a = (a); \
| ^~
../lib/eal/include/rte_common.h:817:34: note: in definition of macro ‘RTE_MAX’
817 | typeof (a) _a = (a); \
| ^
../drivers/net/sfc/sfc_ef10_essb_rx.c:535:33: note: in expansion of macro ‘SFC_DIV_ROUND_UP’
535 | nb_hw_rx_desc = RTE_MAX(SFC_DIV_ROUND_UP(nb_rx_desc,
| ^~~~~~~~~~~~~~~~
../lib/eal/include/rte_common.h:817:28: note: shadowed declaration is here
817 | typeof (a) _a = (a); \
| ^~
../drivers/net/sfc/sfc_ef10_essb_rx.c:535:25: note: in expansion of macro ‘RTE_MAX’
535 | nb_hw_rx_desc = RTE_MAX(SFC_DIV_ROUND_UP(nb_rx_desc,
|
But no extra warnings in the base driver.
Thank you.
From: Stephen Hemminger <stephen@networkplumber.org> Date: 2025-07-11 16:31:30
On Fri, 11 Jul 2025 19:13:01 +0400 (+04)
Ivan Malov [off-list ref] wrote:
On Fri, 11 Jul 2025, Stephen Hemminger wrote:
quoted
On Fri, 11 Jul 2025 18:43:46 +0400
Ivan Malov [off-list ref] wrote:
quoted
The 25.07 release has got support for AMD Solarflare X45xx adapters [1].
This series is a follow-up to [1] to fix compiler warnings in the base
driver that are seen in Windows driver build, also based on this driver.
[1] https://patches.dpdk.org/project/dpdk/list/?series=35095
Ivan Malov (3):
common/sfc_efx/base: fix compiler warnings in statistic code
common/sfc_efx/base: fix compiler warnings in PHY link setup
common/sfc_efx/base: fix compiler warning in PHY link getter
drivers/common/sfc_efx/base/efx_np.c | 7 ++-----
drivers/common/sfc_efx/base/medford4_phy.c | 1 -
2 files changed, 2 insertions(+), 6 deletions(-)
Have your tried enabling -Wshadow and -Wduplicated-branches and -Wduplicated-cond
Those flags are finding stuff in other places.
Thanks Stephen. That is very useful. I tried adding these flags via meson.build
for common/sfc_efx, common/sfc_efx/base and for net/sfc trees and the only thing
I was able to find is as follows:
In file included from ../lib/eal/x86/include/rte_byteorder.h:9,
from ../drivers/net/sfc/sfc_ef10_essb_rx.c:14:
../drivers/net/sfc/sfc_ef10_essb_rx.c: In function ‘sfc_ef10_essb_rx_qsize_up_rings’:
../drivers/net/sfc/sfc_dp.h:27:27: warning: declaration of ‘_a’ shadows a previous local [-Wshadow]
27 | typeof(a) _a = (a); \
| ^~
../lib/eal/include/rte_common.h:817:34: note: in definition of macro ‘RTE_MAX’
817 | typeof (a) _a = (a); \
| ^
../drivers/net/sfc/sfc_ef10_essb_rx.c:535:33: note: in expansion of macro ‘SFC_DIV_ROUND_UP’
535 | nb_hw_rx_desc = RTE_MAX(SFC_DIV_ROUND_UP(nb_rx_desc,
| ^~~~~~~~~~~~~~~~
../lib/eal/include/rte_common.h:817:28: note: shadowed declaration is here
817 | typeof (a) _a = (a); \
| ^~
../drivers/net/sfc/sfc_ef10_essb_rx.c:535:25: note: in expansion of macro ‘RTE_MAX’
535 | nb_hw_rx_desc = RTE_MAX(SFC_DIV_ROUND_UP(nb_rx_desc,
|
But no extra warnings in the base driver.
Thank you.
Good thanks, RTE_MIN/RTE_MAX has issues when nested. Not sure if there is an easy fix.
From: Stephen Hemminger <stephen@networkplumber.org> Date: 2025-07-22 03:51:02
On Fri, 11 Jul 2025 18:43:46 +0400
Ivan Malov [off-list ref] wrote:
The 25.07 release has got support for AMD Solarflare X45xx adapters [1].
This series is a follow-up to [1] to fix compiler warnings in the base
driver that are seen in Windows driver build, also based on this driver.
[1] https://patches.dpdk.org/project/dpdk/list/?series=35095
Ivan Malov (3):
common/sfc_efx/base: fix compiler warnings in statistic code
common/sfc_efx/base: fix compiler warnings in PHY link setup
common/sfc_efx/base: fix compiler warning in PHY link getter
drivers/common/sfc_efx/base/efx_np.c | 7 ++-----
drivers/common/sfc_efx/base/medford4_phy.c | 1 -
2 files changed, 2 insertions(+), 6 deletions(-)
--
From: Ivan Malov <hidden> Date: 2025-08-02 04:30:23
The 25.07 release has got support for AMD Solarflare X45xx adapters [1].
This series is a follow-up to [1] to fix compiler warnings in the base
driver that are seen in Windows driver build, also based on this driver.
[1] https://patches.dpdk.org/project/dpdk/list/?series=35095
v2:
- re-group the changes the way Andrew suggested
- include Cc to 'stable', to have this in 25.07
Ivan Malov (2):
common/sfc_efx/base: resolve warnings about unused variables
common/sfc_efx/base: clean up type-related compiler warnings
drivers/common/sfc_efx/base/efx_np.c | 7 ++-----
drivers/common/sfc_efx/base/medford4_phy.c | 1 -
2 files changed, 2 insertions(+), 6 deletions(-)
--
2.39.5
From: Ivan Malov <hidden> Date: 2025-08-02 04:30:30
Fixes: 2a5cf77e6de8 ("common/sfc_efx/base: provide PHY link get method on Medford4")
Fixes: 8e79cd30230d ("common/sfc_efx/base: implement PHY link control for Medford4")
Fixes: f2f77453cb9f ("common/sfc_efx/base: fill in software LUT for MAC statistics")
Cc: stable@dpdk.org
Suggested-by: Andy Moreton <redacted>
Signed-off-by: Ivan Malov <redacted>
---
drivers/common/sfc_efx/base/efx_np.c | 3 ---
drivers/common/sfc_efx/base/medford4_phy.c | 1 -
2 files changed, 4 deletions(-)
From: Ivan Malov <hidden> Date: 2025-08-02 04:30:36
Fixes: 8e79cd30230d ("common/sfc_efx/base: implement PHY link control for Medford4")
Fixes: f2f77453cb9f ("common/sfc_efx/base: fill in software LUT for MAC statistics")
Cc: stable@dpdk.org
Suggested-by: Andy Moreton <redacted>
Signed-off-by: Ivan Malov <redacted>
---
drivers/common/sfc_efx/base/efx_np.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From: Andrew Rybchenko <hidden> Date: 2025-08-02 08:20:51
On 8/2/25 07:30, Ivan Malov wrote:
The 25.07 release has got support for AMD Solarflare X45xx adapters [1].
This series is a follow-up to [1] to fix compiler warnings in the base
driver that are seen in Windows driver build, also based on this driver.
[1] https://patches.dpdk.org/project/dpdk/list/?series=35095
v2:
- re-group the changes the way Andrew suggested
- include Cc to 'stable', to have this in 25.07
Ivan Malov (2):
common/sfc_efx/base: resolve warnings about unused variables
common/sfc_efx/base: clean up type-related compiler warnings
drivers/common/sfc_efx/base/efx_np.c | 7 ++-----
drivers/common/sfc_efx/base/medford4_phy.c | 1 -
2 files changed, 2 insertions(+), 6 deletions(-)
From: Stephen Hemminger <stephen@networkplumber.org> Date: 2025-08-02 20:59:40
On Sat, 2 Aug 2025 08:30:08 +0400
Ivan Malov [off-list ref] wrote:
The 25.07 release has got support for AMD Solarflare X45xx adapters [1].
This series is a follow-up to [1] to fix compiler warnings in the base
driver that are seen in Windows driver build, also based on this driver.
[1] https://patches.dpdk.org/project/dpdk/list/?series=35095
v2:
- re-group the changes the way Andrew suggested
- include Cc to 'stable', to have this in 25.07
Ivan Malov (2):
common/sfc_efx/base: resolve warnings about unused variables
common/sfc_efx/base: clean up type-related compiler warnings
drivers/common/sfc_efx/base/efx_np.c | 7 ++-----
drivers/common/sfc_efx/base/medford4_phy.c | 1 -
2 files changed, 2 insertions(+), 6 deletions(-)