[PATCH] common/qat: fix overrun of qp config

Subsystems: the rest

STALE1727d

3 messages, 3 authors, 2021-11-16 · open the first message on its own page

[PATCH] common/qat: fix overrun of qp config

From: Arek Kusztal <hidden>
Date: 2021-11-12 12:02:08

This commint fixes overrun of ring configuration
due to insufficient check.

Fixes: 4badfb0205f7 ("common/qat: fix queue pairs number")
Cc: przemyslawx.zegan@intel.com

Signed-off-by: Arek Kusztal <redacted>
---
 drivers/common/qat/dev/qat_dev_gen1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/common/qat/dev/qat_dev_gen1.c b/drivers/common/qat/dev/qat_dev_gen1.c
index 64d02e4817..c34ae5a51c 100644
--- a/drivers/common/qat/dev/qat_dev_gen1.c
+++ b/drivers/common/qat/dev/qat_dev_gen1.c
@@ -95,7 +95,7 @@ qat_qp_rings_per_service_gen1(struct qat_pci_device *qat_dev,
 
 		if (hw_qps == NULL)
 			continue;
-		if (hw_qps->service_type == service)
+		if (hw_qps->service_type == service && hw_qps->tx_msg_size)
 			count++;
 	}
 
-- 
2.17.1

RE: [PATCH] common/qat: fix overrun of qp config

From: Power, Ciara <hidden>
Date: 2021-11-12 14:03:53

Hi Arek,
-----Original Message-----
From: Kusztal, ArkadiuszX <redacted>
Sent: Friday 12 November 2021 12:02
To: dev@dpdk.org
Cc: gakhil@marvell.com; Zhang, Roy Fan <redacted>; Power,
Ciara [off-list ref]; Kusztal, ArkadiuszX
[off-list ref]; Zegan, PrzemyslawX
[off-list ref]
Subject: [PATCH] common/qat: fix overrun of qp config

This commint fixes overrun of ring configuration due to insufficient check.
Small typo here: commint -> commit
Fixes: 4badfb0205f7 ("common/qat: fix queue pairs number")
Cc: przemyslawx.zegan@intel.com

Signed-off-by: Arek Kusztal <redacted>
---
Asides from that, the patch looks good to me.
Acked-by: Ciara Power <redacted>

RE: [PATCH] common/qat: fix overrun of qp config

From: Akhil Goyal <hidden>
Date: 2021-11-16 07:31:47

quoted
Subject: [PATCH] common/qat: fix overrun of qp config

This commint fixes overrun of ring configuration due to insufficient check.
Small typo here: commint -> commit
Fixed while merging.
quoted
Fixes: 4badfb0205f7 ("common/qat: fix queue pairs number")
Cc: przemyslawx.zegan@intel.com

Signed-off-by: Arek Kusztal <redacted>
---
Asides from that, the patch looks good to me.
Acked-by: Ciara Power <redacted>
Applied to dpdk-next-crypto
Cc:stable@dpdk.org
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help