Dead code in compress/octeontx ?

From: David Marchand <hidden>
Date: 2021-11-10 16:28:35

Looking at drivers/compress/octeontx/meson.build:
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Cavium, Inc

if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
    build = false
    reason = 'only supported on 64-bit Linux'
    subdir_done()
endif

sources = files('otx_zip.c', 'otx_zip_pmd.c')
includes += include_directories('include')
deps += ['mempool_octeontx', 'bus_pci']
ext_deps += dep


We have a reference to a "dep" token for external dependencies.
But. I see no dep variable defined in this file.

Correct me if I am wrong, but I understand this driver meson.build
inherits some dep variable that was previously set evaluating other
meson.build in dpdk.

If this is the case, I guess we can drop it.


-- 
David Marchand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help