[dpdk-dev] [PATCH v1] net/ice: fix DCF be configured with bandwidth limit

From: Ting Xu <hidden>
Date: 2021-07-06 08:57:11
Subsystem: networking drivers, the rest · Maintainers: Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

When configuring QoS Tx bandwidth limit, DCF (VF0) is taken into account
and its bandwidth may be configured as well. Since DCF does not handle
traffic, it is no need to configure its bandwidth, which could even
have negative influence on other VFs bandwidth configuration. This patch
just skips the step to configure DCF bandwidth.

Fixes: 3a5a5bfc618b ("net/ice: support QoS config VF bandwidth in DCF")
Cc: stable@dpdk.org

Signed-off-by: Ting Xu <redacted>
---
 drivers/net/ice/ice_dcf_sched.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_dcf_sched.c b/drivers/net/ice/ice_dcf_sched.c
index 4371bbc820..875b563bfc 100644
--- a/drivers/net/ice/ice_dcf_sched.c
+++ b/drivers/net/ice/ice_dcf_sched.c
@@ -690,7 +690,10 @@ static int ice_dcf_hierarchy_commit(struct rte_eth_dev *dev,
 			VIRTCHNL_DCF_BW_PIR | VIRTCHNL_DCF_BW_CIR;
 	}
 
-	for (vf_id = 0; vf_id < hw->num_vfs; vf_id++) {
+	/* start with VF1, skip VF0 since DCF does not need to configure
+	 * bandwidth for itself
+	 */
+	for (vf_id = 1; vf_id < hw->num_vfs; vf_id++) {
 		num_elem = 0;
 		vf_bw->vf_id = vf_id;
 		vf_bw->node_type = VIRTCHNL_DCF_TARGET_VF_BW;
-- 
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help