[dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable

Subsystems: the rest

2 messages, 2 authors, 2021-02-03 · open the first message on its own page

[dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable

From: Timothy McDaniel <hidden>
Date: 2021-02-03 16:56:57

Fixes: eb14a3421afd ("event/dlb: add eventdev start")
Coverity issue: 366205

Signed-off-by: Timothy McDaniel <redacted>
---
 drivers/event/dlb/dlb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c
index 64e6df7..b580dc9 100644
--- a/drivers/event/dlb/dlb.c
+++ b/drivers/event/dlb/dlb.c
@@ -1847,7 +1847,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
 {
 	struct dlb_hw_dev *handle = &dlb->qm_instance;
 	struct dlb_create_dir_queue_args cfg;
-	struct dlb_cmd_response response;
+	struct dlb_cmd_response response = {0};
 	int32_t ret;
 
 	cfg.response = (uintptr_t)&response;
-- 
1.7.10

Re: [dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable

From: Jerin Jacob <hidden>
Date: 2021-02-03 16:59:02

On Wed, Feb 3, 2021 at 10:26 PM Timothy McDaniel
[off-list ref] wrote:
Please add a comment and also squash the similar patches.

quoted hunk
Fixes: eb14a3421afd ("event/dlb: add eventdev start")
Coverity issue: 366205

Signed-off-by: Timothy McDaniel <redacted>
---
 drivers/event/dlb/dlb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c
index 64e6df7..b580dc9 100644
--- a/drivers/event/dlb/dlb.c
+++ b/drivers/event/dlb/dlb.c
@@ -1847,7 +1847,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
 {
        struct dlb_hw_dev *handle = &dlb->qm_instance;
        struct dlb_create_dir_queue_args cfg;
-       struct dlb_cmd_response response;
+       struct dlb_cmd_response response = {0};
        int32_t ret;

        cfg.response = (uintptr_t)&response;
--
1.7.10
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help