Thread (12 messages) 12 messages, 3 authors, 2021-02-22

Re: [dpdk-dev] [PATCH] net: redefine array size macros

From: Ferruh Yigit <hidden>
Date: 2021-02-02 12:30:48

On 2/1/2021 10:32 PM, Andrew Boyer wrote:
quoted
On Feb 1, 2021, at 5:28 PM, Thomas Monjalon <thomas@monjalon.net 
<mailto:thomas@monjalon.net>> wrote:

29/01/2021 23:44, Andrew Boyer:
quoted
Replace copies of size(arr)/size(arr[0]) with RTE_DIM().
Eventually all of these macro definitions should be removed.

Signed-off-by: Andrew Boyer <aboyer@pensando.io <mailto:aboyer@pensando.io>>
---
drivers/net/atlantic/atl_hw_regs.h                | 2 +-
drivers/net/axgbe/axgbe_common.h                  | 2 +-
drivers/net/bnx2x/bnx2x.h                         | 2 +-
drivers/net/bnx2x/elink.h                         | 2 +-
drivers/net/ena/ena_ethdev.c                      | 2 +-
drivers/net/enic/base/vnic_devcmd.h               | 2 +-
drivers/net/hns3/hns3_ethdev.h                    | 2 +-
drivers/net/i40e/base/i40e_osdep.h                | 2 +-
drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 2 +-
drivers/net/thunderx/base/nicvf_hw.h              | 2 +-
10 files changed, 10 insertions(+), 10 deletions(-)
Thanks for the cleanup.

In the title, the prefix "net" means librte_net.
Here, it should be "drivers/net". I know it's confusing :)

Please check other patches in the series,
they are versioned as v2 and numbered 4/13 and 6/13.
Thank you for the review - do you want me to resend or can you fix it up yourself?
I can fix the title while merging, thanks for cleanup,

Reviewed-by: Ferruh Yigit <redacted>
The 4/13 and 6/13 are fixups that Ferruh asked for, while he applied the rest of 
the series. I made the 4/13 a v2 replying to the original 4/13 and the 6/13 a v2 
replying to the original 6/13. If I messed it up, my apologies!

-Andrew
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help