[dpdk-dev] [PATCH v2] net/virtio: improve logs in Vhost-vDPA DMA mapping

Subsystems: networking drivers, the rest

3 messages, 2 authors, 2021-01-08 · open the first message on its own page

[dpdk-dev] [PATCH v2] net/virtio: improve logs in Vhost-vDPA DMA mapping

From: Maxime Coquelin <hidden>
Date: 2021-01-05 15:34:59

This patch adds debug logs in vhost_vdpa_dma_map() and
vhost_vdpa_dma_unmap() to ease debugging.

Signed-off-by: Maxime Coquelin <redacted>
---

Changes in v2:
 - fix i686 build (Chenbo)

 drivers/net/virtio/virtio_user/vhost_vdpa.c | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/drivers/net/virtio/virtio_user/vhost_vdpa.c b/drivers/net/virtio/virtio_user/vhost_vdpa.c
index c7b9349fc8..c5b59e2f95 100644
--- a/drivers/net/virtio/virtio_user/vhost_vdpa.c
+++ b/drivers/net/virtio/virtio_user/vhost_vdpa.c
@@ -93,6 +93,9 @@ vhost_vdpa_dma_map(struct virtio_user_dev *dev, void *addr,
 	msg.iotlb.size = len;
 	msg.iotlb.perm = VHOST_ACCESS_RW;
 
+	PMD_DRV_LOG(DEBUG, "%s: iova: 0x%" PRIx64 ", addr: %p, len: 0x%zx",
+			__func__, iova, addr, len);
+
 	if (write(dev->vhostfd, &msg, sizeof(msg)) != sizeof(msg)) {
 		PMD_DRV_LOG(ERR, "Failed to send IOTLB update (%s)",
 				strerror(errno));
@@ -113,6 +116,9 @@ vhost_vdpa_dma_unmap(struct virtio_user_dev *dev, __rte_unused void *addr,
 	msg.iotlb.iova = iova;
 	msg.iotlb.size = len;
 
+	PMD_DRV_LOG(DEBUG, "%s: iova: 0x%" PRIx64 ", len: 0x%zx",
+			__func__, iova, len);
+
 	if (write(dev->vhostfd, &msg, sizeof(msg)) != sizeof(msg)) {
 		PMD_DRV_LOG(ERR, "Failed to send IOTLB invalidate (%s)",
 				strerror(errno));
-- 
2.29.2

Re: [dpdk-dev] [PATCH v2] net/virtio: improve logs in Vhost-vDPA DMA mapping

From: Xia, Chenbo <hidden>
Date: 2021-01-08 07:37:01

quoted hunk
-----Original Message-----
From: Maxime Coquelin <redacted>
Sent: Tuesday, January 5, 2021 11:35 PM
To: dev@dpdk.org; Xia, Chenbo <redacted>; amorenoz@redhat.com
Cc: Maxime Coquelin <redacted>
Subject: [PATCH v2] net/virtio: improve logs in Vhost-vDPA DMA mapping

This patch adds debug logs in vhost_vdpa_dma_map() and
vhost_vdpa_dma_unmap() to ease debugging.

Signed-off-by: Maxime Coquelin <redacted>
---

Changes in v2:
 - fix i686 build (Chenbo)

 drivers/net/virtio/virtio_user/vhost_vdpa.c | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/drivers/net/virtio/virtio_user/vhost_vdpa.c
b/drivers/net/virtio/virtio_user/vhost_vdpa.c
index c7b9349fc8..c5b59e2f95 100644
--- a/drivers/net/virtio/virtio_user/vhost_vdpa.c
+++ b/drivers/net/virtio/virtio_user/vhost_vdpa.c
@@ -93,6 +93,9 @@ vhost_vdpa_dma_map(struct virtio_user_dev *dev, void *addr,
 	msg.iotlb.size = len;
 	msg.iotlb.perm = VHOST_ACCESS_RW;

+	PMD_DRV_LOG(DEBUG, "%s: iova: 0x%" PRIx64 ", addr: %p, len: 0x%zx",
+			__func__, iova, addr, len);
+
 	if (write(dev->vhostfd, &msg, sizeof(msg)) != sizeof(msg)) {
 		PMD_DRV_LOG(ERR, "Failed to send IOTLB update (%s)",
 				strerror(errno));
@@ -113,6 +116,9 @@ vhost_vdpa_dma_unmap(struct virtio_user_dev *dev,
__rte_unused void *addr,
 	msg.iotlb.iova = iova;
 	msg.iotlb.size = len;

+	PMD_DRV_LOG(DEBUG, "%s: iova: 0x%" PRIx64 ", len: 0x%zx",
+			__func__, iova, len);
+
 	if (write(dev->vhostfd, &msg, sizeof(msg)) != sizeof(msg)) {
 		PMD_DRV_LOG(ERR, "Failed to send IOTLB invalidate (%s)",
 				strerror(errno));
--
2.29.2
Reviewed-by: Chenbo Xia <redacted>

Re: [dpdk-dev] [PATCH v2] net/virtio: improve logs in Vhost-vDPA DMA mapping

From: Maxime Coquelin <hidden>
Date: 2021-01-08 09:18:50


On 1/5/21 4:34 PM, Maxime Coquelin wrote:
This patch adds debug logs in vhost_vdpa_dma_map() and
vhost_vdpa_dma_unmap() to ease debugging.

Signed-off-by: Maxime Coquelin <redacted>
---

Changes in v2:
 - fix i686 build (Chenbo)

 drivers/net/virtio/virtio_user/vhost_vdpa.c | 6 ++++++
 1 file changed, 6 insertions(+)
Series applied to dpdk-next-virtio/main.

Thanks,
Maxime
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help