On 12/17/18 3:41 PM, Wang, Xiao W wrote:

Thanks for the confirmation.

Please note that CI reports a checkpatch issue:
http://patches.dpdk.org/patch/48935/

Thanks,
Maxime

BRs,
Xiao

quoted

-----Original Message-----
From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
Sent: Monday, December 17, 2018 7:03 PM
To: Wang, Xiao W <redacted>; Bie, Tiwei <redacted>
Cc: alejandro.lucero@netronome.com; dev@dpdk.org; Wang, Zhihong
[off-list ref]; Ye, Xiaolong [off-list ref]
Subject: Re: [PATCH v4 03/10] vhost: provide helpers for virtio ring relay

Hi Xiao,

On 12/17/18 9:51 AM, Wang, Xiao W wrote:

quoted

Hi Maxime,

quoted

-----Original Message-----
From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
Sent: Sunday, December 16, 2018 1:11 AM
To: Wang, Xiao W <redacted>; Bie, Tiwei

[off-list ref]

quoted

quoted

Cc: alejandro.lucero@netronome.com; dev@dpdk.org; Wang, Zhihong
[off-list ref]; Ye, Xiaolong [off-list ref]
Subject: Re: [PATCH v4 03/10] vhost: provide helpers for virtio ring relay



On 12/14/18 10:16 PM, Xiao Wang wrote:

quoted

This patch provides two helpers for vdpa device driver to perform a
relay between the guest virtio ring and a mediate virtio ring.

s/mediate/mediated/ ?
I'm not 100% sure, but if it is mediated, please change everywhere else
in the patch.

"mediate" can also be used as an adjective, so "mediate" is OK here.

I got the confirmation from a native speaker that mediate sounds wrong
in this context, and mediated should be used.

quoted

quoted

quoted

The available ring relay will synchronize the available entries, and
helps to do desc validity checking.

s/helps/help/

Yes, will update.

quoted

quoted

The used ring relay will synchronize the used entries from mediate ring
to guest ring, and helps to do dirty page logging for live migration.

s/helps/help/

Will update.

Thanks for the comments,
Xiao

quoted

quoted

The next patch will leverage these two helpers.

Signed-off-by: Xiao Wang <redacted>
---
    lib/librte_vhost/rte_vdpa.h            |  39 +++++++
    lib/librte_vhost/rte_vhost_version.map |   2 +
    lib/librte_vhost/vdpa.c                | 194

+++++++++++++++++++++++++++++++++

quoted

    lib/librte_vhost/vhost.h               |  40 +++++++
    lib/librte_vhost/virtio_net.c          |  39 -------
    5 files changed, 275 insertions(+), 39 deletions(-)

Appart from that:
Reviewed-by: Maxime Coquelin <redacted>

Thanks,
Maxime