Hi Stephen,

Please would you like to send a v4?


22/06/2018 11:12, Iremonger, Bernard:

Hi Stephen,

quoted

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
Sent: Monday, June 18, 2018 10:36 PM
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH v3 1/3] testpmd: add ability to set tx IP and UDP
parameters

Use RFC standard values for Tx only test as defaults.
But let the user override those values on command line.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---

<snip>

quoted

 app/test-pmd/parameters.c             | 49 +++++++++++++++++++++++++++

diff --git a/doc/guides/testpmd_app_ug/run_app.rst

b/doc/guides/testpmd_app_ug/run_app.rst
index f301c2b6f709..ae9eb712e209 100644

--- a/doc/guides/testpmd_app_ug/run_app.rst
+++ b/doc/guides/testpmd_app_ug/run_app.rst

@@ -249,6 +249,15 @@ The commandline options are:
     Set the MAC address ``XX:XX:XX:XX:XX:XX`` of the peer port N,
     where 0 <= N < ``CONFIG_RTE_MAX_ETHPORTS`` from the configuration file.

+
+*   ``--tx-ip=SRC,DST``

A newline should be inserted after the above line to maintain the existing format of the output HTML file.

quoted

+    Set the source and destination IP address used when doing transmit only test.
+    The defaults are source 192.18.0.1 and destination 192.18.0.2.
+
+*   ``--tx-udp=SRC[,DST]``

A newline should be inserted after the above line to maintain the existing format of the output HTML file.

quoted

+    Set the source and destination UDP port number for transmit test only test.
+    The default port is the 9 (discard).
+
 *   ``--pkt-filter-mode=mode``

     Set Flow Director mode where mode is either ``none`` (the default),
``signature`` or ``perfect``.
--
2.17.1

dpdk/devtools/check-git-log.sh -1
Wrong headline label:
        testpmd: add ability to set tx IP and UDP parameters
Wrong headline lowercase:
        testpmd: add ability to set tx IP and UDP parameters

The headline label should be "app/testpmd:"
"tx" should "Tx"

I commented on this previously.

Regards,

Bernard.