[PATCH] ethdev: move internal callback list definition

Subsystems: library code, the rest

STALE3150d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2018-01-24 · open the first message on its own page

[PATCH] ethdev: move internal callback list definition

From: David Marchand <hidden>
Date: 2018-01-22 12:25:40

This structure is not exposed through public apis, we should just move it
to the core header.

Signed-off-by: David Marchand <redacted>
Reviewed-by: Ferruh Yigit <redacted>
---
 lib/librte_ether/rte_ethdev.h      | 4 ----
 lib/librte_ether/rte_ethdev_core.h | 4 ++++
 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index ccf4a15..1a5b4cd 100644
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -1120,10 +1120,6 @@ struct rte_eth_dev;
 
 #define RTE_ETH_ALL RTE_MAX_ETHPORTS
 
-struct rte_eth_dev_callback;
-/** @internal Structure to keep track of registered callbacks */
-TAILQ_HEAD(rte_eth_dev_cb_list, rte_eth_dev_callback);
-
 /* Macros to check for valid port */
 #define RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, retval) do { \
 	if (!rte_eth_dev_is_valid_port(port_id)) { \
diff --git a/lib/librte_ether/rte_ethdev_core.h b/lib/librte_ether/rte_ethdev_core.h
index f44b40e..3073e78 100644
--- a/lib/librte_ether/rte_ethdev_core.h
+++ b/lib/librte_ether/rte_ethdev_core.h
@@ -17,6 +17,10 @@
  *
  */
 
+struct rte_eth_dev_callback;
+/** @internal Structure to keep track of registered callbacks */
+TAILQ_HEAD(rte_eth_dev_cb_list, rte_eth_dev_callback);
+
 /*
  * Definitions of all functions exported by an Ethernet driver through the
  * the generic structure of type *eth_dev_ops* supplied in the *rte_eth_dev*
-- 
2.7.4

Re: [PATCH] ethdev: move internal callback list definition

From: Ferruh Yigit <hidden>
Date: 2018-01-24 15:58:52

On 1/22/2018 12:25 PM, David Marchand wrote:
This structure is not exposed through public apis, we should just move it
to the core header.

Signed-off-by: David Marchand <redacted>
Reviewed-by: Ferruh Yigit <redacted>
Applied to dpdk-next-net/master, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help