Thread (32 messages) 32 messages, 4 authors, 2018-08-16

Re: [PATCH v2] checkpatches.sh: Add checks for ABI symbol addition

From: Thomas Monjalon <hidden>
Date: 2018-01-22 02:06:13

22/01/2018 02:54, Neil Horman:
On Sun, Jan 21, 2018 at 09:29:18PM +0100, Thomas Monjalon wrote:
quoted
quoted
 	$verbose || printf '\n### %s\n\n' "$3"
 	printf '%s\n' "$report" | sed -n '1,/^total:.*lines checked$/p'
+
+	echo
+	echo "Checking API additions/removals:"
You should respect $verbose before printing such header.
I can add a quiet/verbose mode option, but I didn't think it was needed here
since its being run automatically from within checkpatches.
I mean there is a verbose option already.
So you just have to take it into account when printing.
Thanks
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help