Changing some part of the libraries but not updating all dependent code
cause maintenance problems.
The update in the contribution guide practically suggest updating all
dependent code.
With the counter argument that sometimes it is not possible to know
details of the dependent code and this prevents improvements, an
exception left for the cases dependent code requires special expertise,
for those cases it is possible left dependent code unchanged with the
condition to not break the existing code. The dependent code maintainer
should do the required update later.
For the cases it is possible to update the dependent code but it
requires extra work, it is expected from author of the original patch to
do that extra work and update dependencies.
Signed-off-by: Ferruh Yigit <redacted>
---
This is a process related update, cc'ing tech board for more comment.
Cc: techboard@dpdk.org
---
doc/guides/contributing/patches.rst | 3 +++
1 file changed, 3 insertions(+)
@@ -130,6 +130,9 @@ Make your planned changes in the cloned ``dpdk`` repo. Here are some guidelines* Don't break compilation between commits with forward dependencies in a patchset. Each commit should compile on its own to allow for ``git bisect`` and continuous integration testing.+* If changes effect other parts of the project, update all those parts as well unless updating requires special knowledge.+ For the cases not all effected code updated, ensure that changes don't break existing code.+* Add tests to the the ``app/test`` unit test framework where possible.* Add documentation, if relevant, in the form of Doxygen comments or a User Guide in RST format.
From: Mcnamara, John <hidden> Date: 2017-12-11 14:26:34
-----Original Message-----
From: Yigit, Ferruh
Sent: Tuesday, November 21, 2017 7:59 PM
To: Thomas Monjalon <redacted>; Mcnamara, John
[off-list ref]
Cc: dev@dpdk.org; Yigit, Ferruh <redacted>;
techboard@dpdk.org
Subject: [PATCH] doc: update contribution guideline for dependent work
Changing some part of the libraries but not updating all dependent code
cause maintenance problems.
...
Signed-off-by: Ferruh Yigit <redacted>
integration testing.
+* If changes effect other parts of the project, update all those parts as
well unless updating requires special knowledge.
+ For the cases not all effected code updated, ensure that changes don't
break existing code.
+
* Add tests to the the ``app/test`` unit test framework where possible.
* Add documentation, if relevant, in the form of Doxygen comments or a
User Guide in RST format.
Second line would be better as:
For the cases where not all the effected code is updated, the submitter should ensure that changes don't break existing code.
Acked-by: John McNamara <redacted>
Hi,
On Mon, Dec 11, 2017 at 02:26:34PM +0000, Mcnamara, John wrote:
From: Yigit, Ferruh
quoted
Changing some part of the libraries but not updating all dependent code
cause maintenance problems.
...
Signed-off-by: Ferruh Yigit <redacted>
integration testing.
quoted
+* If changes effect other parts of the project, update all those parts as
well unless updating requires special knowledge.
I feel that "requiring special knowledge" is a bit blury. Shouldn't we add some
examples? Typically, I'm thinking about changes in ethdev that imply updating
the PMDs. Any opinion for this use case?
Hi,
On Mon, Dec 11, 2017 at 02:26:34PM +0000, Mcnamara, John wrote:
quoted
From: Yigit, Ferruh
quoted
Changing some part of the libraries but not updating all dependent code
cause maintenance problems.
...
Signed-off-by: Ferruh Yigit <redacted>
integration testing.
quoted
+* If changes effect other parts of the project, update all those parts as
well unless updating requires special knowledge.
I feel that "requiring special knowledge" is a bit blury.
Yes it is, but hard to define where to put the line. My point is if author has
enough knowledge to go and update dependent part, please do so.
Shouldn't we add some
examples? Typically, I'm thinking about changes in ethdev that imply updating
the PMDs. Any opinion for this use case?
Overall many libraries to PMDs fit into this. eal/mbuf/ethdev -> PMD changes.
I think, the dynamic logging update in the other libraries and PMDs should be
done with the original patch, adding dynamic logging to any library doesn't
require library specific information, but agree this is more work.
For new ethdev offload method, I believe it fits into more gray area, it may be
possible to update PMDs to use new offloading method but some part PMDs can be
challenging.
Converting flow director filtering to the rte_flow filtering is something I
believe fair to expect from PMD owner instead of rte_flow author.
On Tue, Dec 12, 2017 at 10:57:48AM -0800, Ferruh Yigit wrote:
On 12/12/2017 7:54 AM, Olivier MATZ wrote:
quoted
Hi,
On Mon, Dec 11, 2017 at 02:26:34PM +0000, Mcnamara, John wrote:
quoted
From: Yigit, Ferruh
quoted
Changing some part of the libraries but not updating all dependent code
cause maintenance problems.
...
Signed-off-by: Ferruh Yigit <redacted>
integration testing.
quoted
+* If changes effect other parts of the project, update all those parts as
well unless updating requires special knowledge.
I feel that "requiring special knowledge" is a bit blury.
Yes it is, but hard to define where to put the line. My point is if author has
enough knowledge to go and update dependent part, please do so.
quoted
Shouldn't we add some
examples? Typically, I'm thinking about changes in ethdev that imply updating
the PMDs. Any opinion for this use case?
Overall many libraries to PMDs fit into this. eal/mbuf/ethdev -> PMD changes.
I think, the dynamic logging update in the other libraries and PMDs should be
done with the original patch, adding dynamic logging to any library doesn't
require library specific information, but agree this is more work.
Being the author of this patchset, I can give my feeling in this particular
case. That's right adding dynamic logging to all libraries may not require
to know the specifics or the library.
I did these changes to help me while debugging the i40e driver. Once
done, it was worth doing clean EAL upstreamable patches to lay the
foundations for a generic dynamic logging system in DPDK. If I had to do
the work for all the libraries, I would not have done it, because it was
really out of scope of my task.
So the choice was between having nothing, or having something which is
not much used at first, but can be more widely adopted over time.
That said, I understand that the problem with the second approach is to
stay for too long in a situation where the old system is used.
For new ethdev offload method, I believe it fits into more gray area, it may be
possible to update PMDs to use new offloading method but some part PMDs can be
challenging.
Converting flow director filtering to the rte_flow filtering is something I
believe fair to expect from PMD owner instead of rte_flow author.
Changing some part of the libraries but not updating all dependent code
cause maintenance problems.
The update in the contribution guide practically suggest updating all
dependent code.
With the counter argument that sometimes it is not possible to know
details of the dependent code and this prevents improvements, an
exception left for the cases dependent code requires special expertise,
for those cases it is possible left dependent code unchanged with the
condition to not break the existing code. The dependent code maintainer
should do the required update later.
For the cases it is possible to update the dependent code but it
requires extra work, it is expected from author of the original patch to
do that extra work and update dependencies.
Signed-off-by: Ferruh Yigit <redacted>
Acked-by: John McNamara <redacted>
---
This is a process related update, cc'ing tech board for more comment.
Cc: techboard@dpdk.org
v2: reworded as suggested.
---
doc/guides/contributing/patches.rst | 3 +++
1 file changed, 3 insertions(+)
@@ -153,6 +153,9 @@ Make your planned changes in the cloned ``dpdk`` repo. Here are some guidelines* Don't break compilation between commits with forward dependencies in a patchset. Each commit should compile on its own to allow for ``git bisect`` and continuous integration testing.+* If changes effect other parts of the project, update all those parts as well unless updating requires special knowledge.+ For the cases where not all the effected code is updated, the submitter should ensure that changes don't break existing code.+* Add tests to the the ``app/test`` unit test framework where possible.* Add documentation, if relevant, in the form of Doxygen comments or a User Guide in RST format.
From: Thomas Monjalon <hidden> Date: 2018-05-24 16:58:04
09/01/2018 16:44, Ferruh Yigit:
+* If changes effect other parts of the project, update all those parts as well unless updating requires special knowledge.
+ For the cases where not all the effected code is updated, the submitter should ensure that changes don't break existing code.
We should review it again in the technical board.
I think we should encourage asking for help to complete a patch
with community's help.
+* If changes effect other parts of the project, update all those parts as well unless updating requires special knowledge.
+ For the cases where not all the effected code is updated, the submitter should ensure that changes don't break existing code.
We should review it again in the technical board.
I think we should encourage asking for help to complete a patch
with community's help.
self-nack
This was process update patch, but it seems lack of consensus for now.
+* If changes effect other parts of the project, update all those parts as well unless updating requires special knowledge.
+ For the cases where not all the effected code is updated, the submitter should ensure that changes don't break existing code.
We should review it again in the technical board.
I think we should encourage asking for help to complete a patch
with community's help.
self-nack
This was process update patch, but it seems lack of consensus for now.