Re: [PATCH] igb_uio: remove device reset in open

-----Original Message-----
From: dev <redacted> on behalf of Harish Patil
[off-list ref]
Date: Friday, October 20, 2017 at 3:18 PM
To: Ferruh Yigit <redacted>, Jingjing Wu
[off-list ref], "Thotton, Shijith" [off-list ref],
Gregory Etelson [off-list ref]
Cc: Thomas Monjalon <redacted>, "dev@dpdk.org" <redacted>,
"stable@dpdk.org" [off-list ref], Jianfeng Tan
[off-list ref], George Prekas [off-list ref], Sergio
Gonzalez Monroy [off-list ref]
Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

[This sender failed our fraud detection checks and may not be who they
appear to be. Learn about spoofing at http://aka.ms/LearnAboutSpoofing]

-----Original Message-----
From: Ferruh Yigit <redacted>
Date: Friday, October 20, 2017 at 9:57 AM
To: Jingjing Wu <redacted>, "Thotton, Shijith"
[off-list ref], Gregory Etelson [off-list ref], Harish
Patil [off-list ref]
Cc: Thomas Monjalon <redacted>, "dev@dpdk.org" <redacted>,
"stable@dpdk.org" [off-list ref], Jianfeng Tan
[off-list ref], George Prekas [off-list ref], Sergio
Gonzalez Monroy [off-list ref]
Subject: Re: [PATCH] igb_uio: remove device reset in open

quoted

On 10/20/2017 9:55 AM, Ferruh Yigit wrote:

quoted

Remove device reset during application start, the reset for application
exit still there.

Reset in open removed because of following comments:
1- Device reset not completed when VF driver loaded, which cause VF PMD
   initialization error.
   Adding delay can solve the issue but will increase driver load time.

2- Reset will be issues all devices unconditionally, not very efficient
   way.

Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of
device file")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <redacted>

Hi Jingjing, Shijith, Gregory, Harish,

Can you please test this on top of current master (which has already
Jingjin's
fix) ?

Thanks,
Ferruh

Ferruh,
Sure, will try and get back to you.
Thanks.

Ferruh and all,
This takes care of our SR-IOV VF issue.
Thanks.

quoted

quoted

---
Cc: Jianfeng Tan <redacted>
Cc: Jingjing Wu <redacted>
Cc: Shijith Thotton <redacted>
Cc: Gregory Etelson <redacted>
Cc: Harish Patil <redacted>
Cc: George Prekas <redacted>
Cc: Sergio Gonzalez Monroy <redacted>
---
 lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c

b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
index f7ef82554..fd320d87d 100644

--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c

@@ -336,8 +336,6 @@ igbuio_pci_open(struct uio_info *info, struct inode

*inode)
     struct pci_dev *dev = udev->pdev;
     int err;

-    pci_reset_function(dev);
-
     /* set bus master, which was cleared by the reset function */
     pci_set_master(dev);