From: Qiming Yang <hidden> Date: 2016-12-02 11:35:27
Add two new commands "show port capa <port>" and "show
port capa all"to diaplay what offload capabilities supported
in ports. It will not only display all the capabilities of
the port, but also the enabling condition for each capability
in the running time.
Signed-off-by: Qiming Yang <redacted>
---
app/test-pmd/cmdline.c | 15 +++--
app/test-pmd/config.c | 172 +++++++++++++++++++++++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
3 files changed, 184 insertions(+), 4 deletions(-)
@@ -5830,14 +5836,15 @@ cmdline_parse_token_string_t cmd_showport_port =TOKEN_STRING_INITIALIZER(structcmd_showport_result,port,"port");cmdline_parse_token_string_tcmd_showport_what=TOKEN_STRING_INITIALIZER(structcmd_showport_result,what,-"info#stats#xstats#fdir#stat_qmap#dcb_tc");+"info#stats#xstats#fdir#stat_qmap#dcb_tc#capa");cmdline_parse_token_num_tcmd_showport_portnum=TOKEN_NUM_INITIALIZER(structcmd_showport_result,portnum,UINT8);cmdline_parse_inst_tcmd_showport={.f=cmd_showport_parsed,.data=NULL,-.help_str="show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X (X = port number)",+.help_str="show|clear port"+"info|stats|xstats|fdir|stat_qmap|dcb_tc|capa X (X = port number)",.tokens={(void*)&cmd_showport_show,(void*)&cmd_showport_port,
From: Mcnamara, John <hidden> Date: 2016-12-02 11:40:36
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
Sent: Friday, December 2, 2016 11:31 AM
To: dev@dpdk.org
Cc: Yang, Qiming <redacted>
Subject: [dpdk-dev] [PATCH] app/testpmd: supported offload capabilities
query
Add two new commands "show port capa <port>" and "show port capa all"to
diaplay what offload capabilities supported in ports. It will not only
display all the capabilities of the port, but also the enabling condition
for each capability in the running time.
Hi,
Thanks for that.
New TestPMD functions should have a corresponding entry in the docs.
John
From: Mcnamara, John <hidden> Date: 2016-12-02 11:42:43
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Mcnamara, John
Sent: Friday, December 2, 2016 11:41 AM
To: Yang, Qiming <redacted>; dev@dpdk.org
Cc: Yang, Qiming <redacted>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: supported offload
capabilities query
quoted
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
Sent: Friday, December 2, 2016 11:31 AM
To: dev@dpdk.org
Cc: Yang, Qiming <redacted>
Subject: [dpdk-dev] [PATCH] app/testpmd: supported offload
capabilities query
Add two new commands "show port capa <port>" and "show port capa
all"to diaplay what offload capabilities supported in ports. It will
not only display all the capabilities of the port, but also the
enabling condition for each capability in the running time.
Hi,
Thanks for that.
New TestPMD functions should have a corresponding entry in the docs.
From: Qiming Yang <hidden> Date: 2016-12-06 07:12:15
Add two new commands "show port capa <port>" and "show
port capa all"to diaplay what offload capabilities supported
in ports. It will not only display all the capabilities of
the port, but also the enabling condition for each capability
in the running time.
Signed-off-by: Qiming Yang <redacted>
---
v2 changes:
* fixed the output style as Ferruh's patch show and add some
descriptions in testpmd_funcs.rst for new functions.
---
---
app/test-pmd/cmdline.c | 15 ++-
app/test-pmd/config.c | 172 ++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
4 files changed, 191 insertions(+), 9 deletions(-)
@@ -51,10 +51,10 @@ If you type a partial command and hit ``<TAB>`` you get a list of the available testpmd> show port <TAB>- info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X- info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc all- stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X- stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc all+ info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|capa X+ info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|capa all+ stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|capa X+ stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|capa all ...
@@ -131,7 +131,7 @@ show port Display information for a given port or all ports::- testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc) (port_id|all)+ testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc|capa) (port_id|all) The available information categories are:
@@ -147,6 +147,8 @@ The available information categories are:*``dcb_tc``: DCB information such as TC mapping.+*``capa``: Supported offload capabilities.+ For example:..code-block:: console
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
Sent: Tuesday, December 6, 2016 3:08 PM
To: dev@dpdk.org
Cc: Yang, Qiming <redacted>
Subject: [dpdk-dev] [PATCH v2] app/testpmd: supported offload capabilities
query
Add two new commands "show port capa <port>" and "show port capa all"to
diaplay what offload capabilities supported in ports. It will not only display all
the capabilities of the port, but also the enabling condition for each capability
in the running time.
Signed-off-by: Qiming Yang <redacted>
---
v2 changes:
* fixed the output style as Ferruh's patch show and add some
descriptions in testpmd_funcs.rst for new functions.
---
---
app/test-pmd/cmdline.c | 15 ++-
app/test-pmd/config.c | 172 ++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
4 files changed, 191 insertions(+), 9 deletions(-)
Please add this new command for the print when "help display" in cmd_help_long_parsed.
Thanks
Jingjing
From: Qiming Yang <hidden> Date: 2016-12-21 02:25:33
Add two new commands "show port capa <port>" and "show
port capa all"to diaplay what offload capabilities supported
in ports. It will not only display all the capabilities of
the port, but also the enabling condition for each capability
in the running time.
Signed-off-by: Qiming Yang <redacted>
---
v2 changes:
* fixed the output style as Ferruh's patch show and add some
descriptions in testpmd_funcs.rst for new functions.
v3 changes:
* add new command in cmd_help_long_parsed.
---
---
app/test-pmd/cmdline.c | 17 ++-
app/test-pmd/config.c | 172 ++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
4 files changed, 192 insertions(+), 10 deletions(-)
@@ -182,7 +182,7 @@ static void cmd_help_long_parsed(void *parsed_result,"Display:\n""--------\n\n"-"show port (info|stats|xstats|fdir|stat_qmap|dcb_tc) (port_id|all)\n"+"show port (info|stats|xstats|fdir|stat_qmap|dcb_tc|capa) (port_id|all)\n"" Display information for port_id, or all.\n\n""show port X rss reta (size) (mask0,mask1,...)\n"
@@ -51,10 +51,10 @@ If you type a partial command and hit ``<TAB>`` you get a list of the available testpmd> show port <TAB>- info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X- info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc all- stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X- stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc all+ info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|capa X+ info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|capa all+ stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|capa X+ stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|capa all ...
@@ -131,7 +131,7 @@ show port Display information for a given port or all ports::- testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc) (port_id|all)+ testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc|capa) (port_id|all) The available information categories are:
@@ -147,6 +147,8 @@ The available information categories are:*``dcb_tc``: DCB information such as TC mapping.+*``capa``: Supported offload capabilities.+ For example:..code-block:: console
That's a good advice. Thanks.
-----Original Message-----
From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
Sent: Wednesday, December 21, 2016 10:37 AM
To: Yang, Qiming <redacted>
Cc: dev@dpdk.org; Wu, Jingjing <redacted>
Subject: Re: [dpdk-dev] [PATCH v3] app/testpmd: supported offload capabilities query
On Wed, Dec 21, 2016 at 10:20:26AM +0800, Qiming Yang wrote:
Add two new commands "show port capa <port>" and "show
I think 'cap' is a more well-known shortening for capability than "capa"?
--yliu
From: Qiming Yang <hidden> Date: 2016-12-23 09:37:03
Add two new commands "show port cap <port>" and "show
port cap all"to diaplay what offload capabilities supported
in ports. It will not only display all the capabilities of
the port, but also the enabling condition for each capability
in the running time.
Signed-off-by: Qiming Yang <redacted>
---
v2 changes:
* fixed the output style as Ferruh's patch show and add some
description in docs for new functions.
v3 changes:
* add new command in cmd_help_long_parsed.
v4 changes:
* use 'cap' instead of 'capa'.
---
---
app/test-pmd/cmdline.c | 17 ++-
app/test-pmd/config.c | 172 ++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
4 files changed, 192 insertions(+), 10 deletions(-)
@@ -182,7 +182,7 @@ static void cmd_help_long_parsed(void *parsed_result,"Display:\n""--------\n\n"-"show port (info|stats|xstats|fdir|stat_qmap|dcb_tc) (port_id|all)\n"+"show port (info|stats|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all)\n"" Display information for port_id, or all.\n\n""show port X rss reta (size) (mask0,mask1,...)\n"
@@ -51,10 +51,10 @@ If you type a partial command and hit ``<TAB>`` you get a list of the available testpmd> show port <TAB>- info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X- info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc all- stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X- stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc all+ info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap X+ info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap all+ stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap X+ stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap all ...
@@ -131,7 +131,7 @@ show port Display information for a given port or all ports::- testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc) (port_id|all)+ testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all) The available information categories are:
@@ -147,6 +147,8 @@ The available information categories are:*``dcb_tc``: DCB information such as TC mapping.+*``cap``: Supported offload capabilities.+ For example:..code-block:: console
-----Original Message-----
From: Yang, Qiming
Sent: Friday, December 23, 2016 5:32 PM
To: dev@dpdk.org
Cc: Wu, Jingjing <redacted>; Yang, Qiming
[off-list ref]
Subject: [PATCH v4] app/testpmd: supported offload capabilities query
Add two new commands "show port cap <port>" and "show port cap all"to
diaplay what offload capabilities supported in ports. It will not only display all
the capabilities of the port, but also the enabling condition for each capability
in the running time.
Signed-off-by: Qiming Yang <redacted>
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
Sent: Friday, December 23, 2016 5:32 PM
To: dev@dpdk.org
Cc: Wu, Jingjing <redacted>; Yang, Qiming
[off-list ref]
Subject: [dpdk-dev] [PATCH v4] app/testpmd: supported offload capabilities
query
Add two new commands "show port cap <port>" and "show port cap all"to
diaplay what offload capabilities supported in ports. It will not only display all
the capabilities of the port, but also the enabling condition for each capability in
the running time.
Signed-off-by: Qiming Yang <redacted>
---
v2 changes:
* fixed the output style as Ferruh's patch show and add some
description in docs for new functions.
v3 changes:
* add new command in cmd_help_long_parsed.
v4 changes:
* use 'cap' instead of 'capa'.
---
---
app/test-pmd/cmdline.c | 17 ++-
app/test-pmd/config.c | 172
++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
4 files changed, 192 insertions(+), 10 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
Hi, Beilei
Nothing is missing. This capability have no switch in DPDK now. So it don't have 'on' or 'off'.
-----Original Message-----
From: Xing, Beilei
Sent: Tuesday, December 27, 2016 4:18 PM
To: Yang, Qiming <redacted>; dev@dpdk.org
Cc: Wu, Jingjing <redacted>; Yang, Qiming <redacted>
Subject: RE: [dpdk-dev] [PATCH v4] app/testpmd: supported offload capabilities query
Hi Qiming,
quoted hunk
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
Sent: Friday, December 23, 2016 5:32 PM
To: dev@dpdk.org
Cc: Wu, Jingjing <redacted>; Yang, Qiming
[off-list ref]
Subject: [dpdk-dev] [PATCH v4] app/testpmd: supported offload
capabilities query
Add two new commands "show port cap <port>" and "show port cap all"to
diaplay what offload capabilities supported in ports. It will not only
display all the capabilities of the port, but also the enabling
condition for each capability in the running time.
Signed-off-by: Qiming Yang <redacted>
---
v2 changes:
* fixed the output style as Ferruh's patch show and add some
description in docs for new functions.
v3 changes:
* add new command in cmd_help_long_parsed.
v4 changes:
* use 'cap' instead of 'capa'.
---
---
app/test-pmd/cmdline.c | 17 ++-
app/test-pmd/config.c | 172
++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
4 files changed, 192 insertions(+), 10 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
Sent: Friday, December 23, 2016 5:32 PM
To: dev@dpdk.org
Cc: Wu, Jingjing <redacted>; Yang, Qiming
[off-list ref]
Subject: [dpdk-dev] [PATCH v4] app/testpmd: supported offload capabilities
query
Add two new commands "show port cap <port>" and "show port cap all"to
diaplay what offload capabilities supported in ports. It will not only display all
the capabilities of the port, but also the enabling condition for each capability in
the running time.
Signed-off-by: Qiming Yang <redacted>
From: Qiming Yang <hidden> Date: 2017-01-12 03:32:16
Add two new commands "show port cap <port>" and "show
port cap all"to diaplay what offload capabilities supported
in ports. It will not only display all the capabilities of
the port, but also the enabling condition for each capability
in the running time.
Signed-off-by: Qiming Yang <redacted>
Acked-by: Jingjing Wu <redacted>
Acked-by: Beilei Xing <redacted>
---
v2 changes:
* fixed the output style as Ferruh's patch show and add some
description in docs for new functions.
v3 changes:
* add new command in cmd_help_long_parsed.
v4 changes:
* use 'cap' instead of 'capa'.
v5 changes:
* rebased, fixed the inappropriate expression and adjusted the
output order.
---
---
app/test-pmd/cmdline.c | 17 ++-
app/test-pmd/config.c | 175 ++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
4 files changed, 195 insertions(+), 10 deletions(-)
@@ -183,7 +183,7 @@ static void cmd_help_long_parsed(void *parsed_result,"Display:\n""--------\n\n"-"show port (info|stats|xstats|fdir|stat_qmap|dcb_tc) (port_id|all)\n"+"show port (info|stats|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all)\n"" Display information for port_id, or all.\n\n""show port X rss reta (size) (mask0,mask1,...)\n"
@@ -51,10 +51,10 @@ If you type a partial command and hit ``<TAB>`` you get a list of the available testpmd> show port <TAB>- info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X- info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc all- stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X- stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc all+ info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap X+ info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap all+ stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap X+ stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap all ...
@@ -131,7 +131,7 @@ show port Display information for a given port or all ports::- testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc) (port_id|all)+ testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all) The available information categories are:
@@ -147,6 +147,8 @@ The available information categories are:*``dcb_tc``: DCB information such as TC mapping.+*``cap``: Supported offload capabilities.+ For example:..code-block:: console
From: De Lara Guarch, Pablo <hidden> Date: 2017-01-13 08:43:19
Hi Qiming,
quoted hunk
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
Sent: Thursday, January 12, 2017 3:26 AM
To: dev@dpdk.org
Cc: Yang, Qiming
Subject: [dpdk-dev] [PATCH v5] app/testpmd: supported offload capabilities
query
Add two new commands "show port cap <port>" and "show
port cap all"to diaplay what offload capabilities supported
in ports. It will not only display all the capabilities of
the port, but also the enabling condition for each capability
in the running time.
Signed-off-by: Qiming Yang <redacted>
Acked-by: Jingjing Wu <redacted>
Acked-by: Beilei Xing <redacted>
---
v2 changes:
* fixed the output style as Ferruh's patch show and add some
description in docs for new functions.
v3 changes:
* add new command in cmd_help_long_parsed.
v4 changes:
* use 'cap' instead of 'capa'.
v5 changes:
* rebased, fixed the inappropriate expression and adjusted the
output order.
---
---
app/test-pmd/cmdline.c | 17 ++-
app/test-pmd/config.c | 175
++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
4 files changed, 195 insertions(+), 10 deletions(-)
Hi, Pablo
-----Original Message-----
From: De Lara Guarch, Pablo
Sent: Friday, January 13, 2017 4:43 PM
To: Yang, Qiming <redacted>; dev@dpdk.org
Cc: Yang, Qiming <redacted>
Subject: RE: [dpdk-dev] [PATCH v5] app/testpmd: supported offload capabilities query
Hi Qiming,
quoted hunk
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
Sent: Thursday, January 12, 2017 3:26 AM
To: dev@dpdk.org
Cc: Yang, Qiming
Subject: [dpdk-dev] [PATCH v5] app/testpmd: supported offload
capabilities query
Add two new commands "show port cap <port>" and "show port cap all"to
diaplay what offload capabilities supported in ports. It will not only
display all the capabilities of the port, but also the enabling
condition for each capability in the running time.
Signed-off-by: Qiming Yang <redacted>
Acked-by: Jingjing Wu <redacted>
Acked-by: Beilei Xing <redacted>
---
v2 changes:
* fixed the output style as Ferruh's patch show and add some
description in docs for new functions.
v3 changes:
* add new command in cmd_help_long_parsed.
v4 changes:
* use 'cap' instead of 'capa'.
v5 changes:
* rebased, fixed the inappropriate expression and adjusted the
output order.
---
---
app/test-pmd/cmdline.c | 17 ++-
app/test-pmd/config.c | 175
++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
4 files changed, 195 insertions(+), 10 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
From: Qiming Yang <hidden> Date: 2017-01-13 13:51:06
Add two new commands "show port cap <port>" and "show
port cap all"to diaplay what offload capabilities supported
in ports. It will not only display all the capabilities of
the port, but also the enabling condition for each capability
in the running time.
Signed-off-by: Qiming Yang <redacted>
Acked-by: Jingjing Wu <redacted>
Acked-by: Beilei Xing <redacted>
---
v2 changes:
* fixed the output style as Ferruh's patch show and add some
description in docs for new functions.
v3 changes:
* add new command in cmd_help_long_parsed.
v4 changes:
* use 'cap' instead of 'capa'.
v5 changes:
* rebased, fixed the inappropriate expression and adjusted the
output order.
v6 changes:
* fixed format problems.
---
app/test-pmd/cmdline.c | 17 ++-
app/test-pmd/config.c | 175 ++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
4 files changed, 195 insertions(+), 10 deletions(-)
@@ -183,7 +183,7 @@ static void cmd_help_long_parsed(void *parsed_result,"Display:\n""--------\n\n"-"show port (info|stats|xstats|fdir|stat_qmap|dcb_tc) (port_id|all)\n"+"show port (info|stats|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all)\n"" Display information for port_id, or all.\n\n""show port X rss reta (size) (mask0,mask1,...)\n"
@@ -51,10 +51,10 @@ If you type a partial command and hit ``<TAB>`` you get a list of the available testpmd> show port <TAB>- info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X- info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc all- stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X- stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc all+ info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap X+ info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap all+ stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap X+ stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap all ...
@@ -131,7 +131,7 @@ show port Display information for a given port or all ports::- testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc) (port_id|all)+ testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all) The available information categories are:
@@ -147,6 +147,8 @@ The available information categories are:*``dcb_tc``: DCB information such as TC mapping.+*``cap``: Supported offload capabilities.+ For example:..code-block:: console
From: De Lara Guarch, Pablo <hidden> Date: 2017-01-13 14:02:24
Hi Qiming,
-----Original Message-----
From: Yang, Qiming
Sent: Friday, January 13, 2017 9:40 AM
To: De Lara Guarch, Pablo; dev@dpdk.org
Subject: RE: [dpdk-dev] [PATCH v5] app/testpmd: supported offload
capabilities query
Hi, Pablo
-----Original Message-----
From: De Lara Guarch, Pablo
Sent: Friday, January 13, 2017 4:43 PM
To: Yang, Qiming <redacted>; dev@dpdk.org
Cc: Yang, Qiming <redacted>
Subject: RE: [dpdk-dev] [PATCH v5] app/testpmd: supported offload
capabilities query
Hi Qiming,
quoted
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
Sent: Thursday, January 12, 2017 3:26 AM
To: dev@dpdk.org
Cc: Yang, Qiming
Subject: [dpdk-dev] [PATCH v5] app/testpmd: supported offload
capabilities query
Add two new commands "show port cap <port>" and "show port cap
all"to
quoted
diaplay what offload capabilities supported in ports. It will not only
display all the capabilities of the port, but also the enabling
condition for each capability in the running time.
Signed-off-by: Qiming Yang <redacted>
Acked-by: Jingjing Wu <redacted>
Acked-by: Beilei Xing <redacted>
---
v2 changes:
* fixed the output style as Ferruh's patch show and add some
description in docs for new functions.
v3 changes:
* add new command in cmd_help_long_parsed.
v4 changes:
* use 'cap' instead of 'capa'.
v5 changes:
* rebased, fixed the inappropriate expression and adjusted the
output order.
---
---
app/test-pmd/cmdline.c | 17 ++-
app/test-pmd/config.c | 175
++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
4 files changed, 195 insertions(+), 10 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
Missing on/off?
Qiming: I didn't find any switch for this feature in DPDK now. I'll fix the
format problem. Thank you.
I just saw your v6. So, what does this mean? If the device is capable of doing this,
but there is no way to enable/disable it, it would mean that it will be enabled or disabled by default, right?
I see that X550 NIC is the only one capable of this. Maybe Wenzhuo can help on clarifying this.
I would say that, if it is enabled when it is capable, then you should print "on",
But printing only "RX Outer IPv4 checksum" does not give any information (when all the rest of the capabilities show on/off).
Thanks,
Pablo
Missing on/off?
Qiming: I didn't find any switch for this feature in DPDK now. I'll
fix the format problem. Thank you.
I just saw your v6. So, what does this mean? If the device is capable of doing this, but there is no way to enable/disable it, it would mean that it will be enabled or disabled by default, right?
I see that X550 NIC is the only one capable of this. Maybe Wenzhuo can help on clarifying this.
I would say that, if it is enabled when it is capable, then you should print "on", But printing only "RX Outer IPv4 checksum" does not give any information (when all the rest of the capabilities show on/off).
Qiming: Ok, I'll check with Wenzhuo, Thank you for your advice for the unsuitable print in this place .
Thanks,
Pablo
Hi, Pablo
I have checked with Wenzhuo, this capability has no way to disable and is always enable if NIC have this capability.
So I'll change the print to " RX Outer IPv4 checksum: on".
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Qiming
Sent: Saturday, January 14, 2017 11:06 AM
To: De Lara Guarch, Pablo <redacted>; dev@dpdk.org
Cc: Lu, Wenzhuo <redacted>
Subject: Re: [dpdk-dev] [PATCH v5] app/testpmd: supported offload capabilities query
HI, Pablo
Missing on/off?
Qiming: I didn't find any switch for this feature in DPDK now. I'll
fix the format problem. Thank you.
I just saw your v6. So, what does this mean? If the device is capable of doing this, but there is no way to enable/disable it, it would mean that it will be enabled or disabled by default, right?
I see that X550 NIC is the only one capable of this. Maybe Wenzhuo can help on clarifying this.
I would say that, if it is enabled when it is capable, then you should print "on", But printing only "RX Outer IPv4 checksum" does not give any information (when all the rest of the capabilities show on/off).
Qiming: Ok, I'll check with Wenzhuo, Thank you for your advice for the unsuitable print in this place .
Thanks,
Pablo
From: Qiming Yang <hidden> Date: 2017-01-16 02:37:25
Add two new commands "show port cap <port>" and "show
port cap all"to diaplay what offload capabilities supported
in ports. It will not only display all the capabilities of
the port, but also the enabling condition for each capability
in the running time.
Signed-off-by: Qiming Yang <redacted>
Acked-by: Jingjing Wu <redacted>
Acked-by: Beilei Xing <redacted>
---
v2 changes:
* fixed the output style as Ferruh's patch show and add some
description in docs for new functions.
v3 changes:
* add new command in cmd_help_long_parsed.
v4 changes:
* use 'cap' instead of 'capa'.
v5 changes:
* rebased, fixed the inappropriate expression and adjusted the
output order.
v6 changes:
* fixed format problems.
v7 changes:
* show the default status of 'RX Outer IPV4 checksum'.
---
app/test-pmd/cmdline.c | 17 ++-
app/test-pmd/config.c | 175 ++++++++++++++++++++++++++++
app/test-pmd/testpmd.h | 1 +
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 12 +-
4 files changed, 195 insertions(+), 10 deletions(-)
@@ -183,7 +183,7 @@ static void cmd_help_long_parsed(void *parsed_result,"Display:\n""--------\n\n"-"show port (info|stats|xstats|fdir|stat_qmap|dcb_tc) (port_id|all)\n"+"show port (info|stats|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all)\n"" Display information for port_id, or all.\n\n""show port X rss reta (size) (mask0,mask1,...)\n"
@@ -51,10 +51,10 @@ If you type a partial command and hit ``<TAB>`` you get a list of the available testpmd> show port <TAB>- info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X- info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc all- stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc X- stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc all+ info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap X+ info [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap all+ stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap X+ stats [Mul-choice STRING]: show|clear port info|stats|xstats|fdir|stat_qmap|dcb_tc|cap all ...
@@ -131,7 +131,7 @@ show port Display information for a given port or all ports::- testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc) (port_id|all)+ testpmd> show port (info|stats|xstats|fdir|stat_qmap|dcb_tc|cap) (port_id|all) The available information categories are:
@@ -147,6 +147,8 @@ The available information categories are:*``dcb_tc``: DCB information such as TC mapping.+*``cap``: Supported offload capabilities.+ For example:..code-block:: console
From: De Lara Guarch, Pablo <hidden> Date: 2017-01-16 10:10:30
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
Sent: Monday, January 16, 2017 2:31 AM
To: dev@dpdk.org
Cc: Yang, Qiming
Subject: [dpdk-dev] [PATCH v7] app/testpmd: supported offload capabilities
query
Add two new commands "show port cap <port>" and "show
port cap all"to diaplay what offload capabilities supported
in ports. It will not only display all the capabilities of
the port, but also the enabling condition for each capability
in the running time.
Signed-off-by: Qiming Yang <redacted>
Acked-by: Jingjing Wu <redacted>
Acked-by: Beilei Xing <redacted>
From: Thomas Monjalon <hidden> Date: 2017-01-30 15:59:50
quoted
Add two new commands "show port cap <port>" and "show
port cap all"to diaplay what offload capabilities supported
in ports. It will not only display all the capabilities of
the port, but also the enabling condition for each capability
in the running time.
Signed-off-by: Qiming Yang <redacted>
Acked-by: Jingjing Wu <redacted>
Acked-by: Beilei Xing <redacted>