[PATCH] nfp: fixing bug when copying mac address

Subsystems: networking drivers, the rest

STALE3675d

2 messages, 2 authors, 2016-09-13 · open the first message on its own page

[PATCH] nfp: fixing bug when copying mac address

From: Alejandro Lucero <hidden>
Date: 2016-08-16 15:31:39

Fixes: defb9a5dd156 ("nfp: introduce driver initialization")

Signed-off-by: Alejandro Lucero <redacted>
---
 drivers/net/nfp/nfp_net.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 45d122d..229c8e6 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2421,8 +2421,8 @@ nfp_net_init(struct rte_eth_dev *eth_dev)
 		eth_random_addr(&hw->mac_addr[0]);
 
 	/* Copying mac address to DPDK eth_dev struct */
-	ether_addr_copy(&eth_dev->data->mac_addrs[0],
-			(struct ether_addr *)hw->mac_addr);
+	ether_addr_copy((struct ether_addr *)hw->mac_addr,
+			&eth_dev->data->mac_addrs[0]);
 
 	PMD_INIT_LOG(INFO, "port %d VendorID=0x%x DeviceID=0x%x "
 		     "mac=%02x:%02x:%02x:%02x:%02x:%02x",
-- 
1.9.1

Re: [PATCH] nfp: fixing bug when copying mac address

From: Ferruh Yigit <hidden>
Date: 2016-09-13 17:13:03

On 8/16/2016 4:31 PM, Alejandro Lucero wrote:
Fixes: defb9a5dd156 ("nfp: introduce driver initialization")

Signed-off-by: Alejandro Lucero <redacted>
check-git-log warning, looks like because of "mac" which should be
uppercase:

Wrong headline lowercase:
        nfp: fixing bug when copying mac address
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help