[PATCH] mk:fix second compile error

Subsystems: the rest

STALE3694d

5 messages, 3 authors, 2016-08-22 · open the first message on its own page

[PATCH] mk:fix second compile error

From: xu,huilong <hidden>
Date: 2016-08-09 06:06:24

when compile different targets on a same environment.
The second compile will failed, because test_resource obj file
can't auto clearn by makfile.

Signed-off-by: xu,huilong <redacted>
---
 mk/rte.app.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index eb28e11..d23e8b9 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP)
 #
 .PHONY: clean
 clean: _postclean
-	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS)
+	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) \
+	test_resource.res test_resource_c.o test_resource_c.res.o
 
 .PHONY: doclean
 doclean:
-- 
1.9.3

Re: [PATCH] mk:fix second compile error

From: Bruce Richardson <hidden>
Date: 2016-08-09 08:27:18

On Tue, Aug 09, 2016 at 02:01:58PM +0800, xu,huilong wrote:
quoted hunk
when compile different targets on a same environment.
The second compile will failed, because test_resource obj file
can't auto clearn by makfile.

Signed-off-by: xu,huilong <redacted>
---
 mk/rte.app.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index eb28e11..d23e8b9 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP)
 #
 .PHONY: clean
 clean: _postclean
-	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS)
+	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS) \
+	test_resource.res test_resource_c.o test_resource_c.res.o
 
This fix looks very specific to the test application, and specific files in
that application. Can it be made more generic so that it will work if we add
other resource files to the test app without us having to modify the top-level
application makefile.

Regards,
/Bruce

Re: [PATCH] mk:fix second compile error

From: Xu, HuilongX <hidden>
Date: 2016-08-11 01:38:48

Hi Thomas,
Could you give me some comments about this patch.
Thanks a lot
quoted hunk
-----Original Message-----
From: Xu, HuilongX
Sent: Tuesday, August 09, 2016 2:02 PM
To: dev@dpdk.org
Cc: Xu, HuilongX
Subject: [dpdk-dev][PATCH] mk:fix second compile error

when compile different targets on a same environment.
The second compile will failed, because test_resource obj file
can't auto clearn by makfile.

Signed-off-by: xu,huilong <redacted>
---
 mk/rte.app.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index eb28e11..d23e8b9 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP)
 #
 .PHONY: clean
 clean: _postclean
-	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS)
+	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS)
\
+	test_resource.res test_resource_c.o test_resource_c.res.o

 .PHONY: doclean
 doclean:
--
1.9.3

Re: [PATCH] mk:fix second compile error

From: Xu, HuilongX <hidden>
Date: 2016-08-19 03:06:11

Hi Brue,
Thanks a lot for your comments. I  will send V2 patch.
-----Original Message-----
From: Richardson, Bruce
Sent: Tuesday, August 09, 2016 4:27 PM
To: Xu, HuilongX
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk:fix second compile error

On Tue, Aug 09, 2016 at 02:01:58PM +0800, xu,huilong wrote:
quoted
when compile different targets on a same environment.
The second compile will failed, because test_resource obj file
can't auto clearn by makfile.

Signed-off-by: xu,huilong <redacted>
---
 mk/rte.app.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mk/rte.app.mk b/mk/rte.app.mk
index eb28e11..d23e8b9 100644
--- a/mk/rte.app.mk
+++ b/mk/rte.app.mk
@@ -263,7 +263,8 @@ $(RTE_OUTPUT)/app/$(APP).map: $(APP)
 #
 .PHONY: clean
 clean: _postclean
-	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS)
+	$(Q)rm -f $(_BUILD_TARGETS) $(_INSTALL_TARGETS) $(_CLEAN_TARGETS)
\
quoted
+	test_resource.res test_resource_c.o test_resource_c.res.o
This fix looks very specific to the test application, and specific files
in
that application. Can it be made more generic so that it will work if we
add
other resource files to the test app without us having to modify the
top-level
application makefile.

Regards,
/Bruce

Re: [PATCH] mk:fix second compile error

From: Thomas Monjalon <hidden>
Date: 2016-08-22 13:55:47

2016-08-09 14:01, xu, huilong:
when compile different targets on a same environment.
The second compile will failed, because test_resource obj file
can't auto clearn by makfile.
I don't understand the error.
Please provide commands and output.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help