[PATCH] nfp: fix non-x86 build

Subsystems: networking drivers, the rest

STALE3872d

3 messages, 3 authors, 2016-03-02 · open the first message on its own page

[PATCH] nfp: fix non-x86 build

From: Thomas Monjalon <hidden>
Date: 2016-02-06 21:52:48

The file sys/io.h was included but it can be unavailable in some
non-x86 toolchains.
As others system includes in the file nfp_net.c, it seems useless,
so the easy fix is to remove them.

Signed-off-by: Thomas Monjalon <redacted>
---
 drivers/net/nfp/nfp_net.c | 11 -----------
 1 file changed, 11 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index bc2089f..283269e 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -39,18 +39,7 @@
  * Netronome vNIC DPDK Poll-Mode Driver: Main entry point
  */
 
-#include <stdio.h>
-#include <stdlib.h>
-#include <stdint.h>
-#include <unistd.h>
-#include <string.h>
-#include <sys/mman.h>
-#include <sys/socket.h>
-#include <sys/io.h>
-#include <assert.h>
-#include <time.h>
 #include <math.h>
-#include <inttypes.h>
 
 #include <rte_byteorder.h>
 #include <rte_common.h>
-- 
2.7.0

Re: [PATCH] nfp: fix non-x86 build

From: Alejandro Lucero <hidden>
Date: 2016-02-08 14:28:00

On Sat, Feb 6, 2016 at 9:51 PM, Thomas Monjalon [off-list ref]
wrote:
quoted hunk
The file sys/io.h was included but it can be unavailable in some
non-x86 toolchains.
As others system includes in the file nfp_net.c, it seems useless,
so the easy fix is to remove them.

Signed-off-by: Thomas Monjalon <redacted>
---
 drivers/net/nfp/nfp_net.c | 11 -----------
 1 file changed, 11 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index bc2089f..283269e 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -39,18 +39,7 @@
  * Netronome vNIC DPDK Poll-Mode Driver: Main entry point
  */

-#include <stdio.h>
-#include <stdlib.h>
-#include <stdint.h>
-#include <unistd.h>
-#include <string.h>
-#include <sys/mman.h>
-#include <sys/socket.h>
-#include <sys/io.h>
-#include <assert.h>
-#include <time.h>
 #include <math.h>
-#include <inttypes.h>

 #include <rte_byteorder.h>
 #include <rte_common.h>
--
2.7.0
This is fine for me.

Thanks

Re: [PATCH] nfp: fix non-x86 build

From: Bruce Richardson <hidden>
Date: 2016-03-02 21:10:41

On Mon, Feb 08, 2016 at 02:27:59PM +0000, Alejandro Lucero wrote:
On Sat, Feb 6, 2016 at 9:51 PM, Thomas Monjalon [off-list ref]
wrote:
quoted
The file sys/io.h was included but it can be unavailable in some
non-x86 toolchains.
As others system includes in the file nfp_net.c, it seems useless,
so the easy fix is to remove them.

Signed-off-by: Thomas Monjalon <redacted>
---
 drivers/net/nfp/nfp_net.c | 11 -----------
 1 file changed, 11 deletions(-)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index bc2089f..283269e 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -39,18 +39,7 @@
  * Netronome vNIC DPDK Poll-Mode Driver: Main entry point
  */

-#include <stdio.h>
-#include <stdlib.h>
-#include <stdint.h>
-#include <unistd.h>
-#include <string.h>
-#include <sys/mman.h>
-#include <sys/socket.h>
-#include <sys/io.h>
-#include <assert.h>
-#include <time.h>
 #include <math.h>
-#include <inttypes.h>

 #include <rte_byteorder.h>
 #include <rte_common.h>
--
2.7.0
This is fine for me.

Thanks
Applied to dpdk-next-net/rel_16_04 with Alejandro's ack

/Bruce
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help