Thread (12 messages) 12 messages, 2 authors, 2015-11-04

Re: [PATCH 3/3] ethdev: prevent segfaults in rte_eth_dev_is_detachable

From: David Marchand <hidden>
Date: 2015-11-03 11:19:51

On Tue, Nov 3, 2015 at 12:10 PM, Thomas Monjalon [off-list ref]
wrote:
2015-10-29 09:55, David Marchand:
quoted
From: Maxime Leroy <redacted>

Some drivers like virtual ones don't specify any driver pointer in the
structure rte_eth_dev.

To prevent segfault, we should check if this pointer is NULL before
dereferencing it.

Signed-off-by: Maxime Leroy <redacted>
Signed-off-by: David Marchand <redacted>
It is not clear what the problem is.
And the driver fields should probably be removed or changed as it too
tigthly
related to the PCI driver.
It does look odd to me as well, quickly went through head, and did not see
a case where this could happen.
Maxime is not available at the moment, so I think I will just drop this
patch.

How about this patchset rebased on head with just the first two patches ?


-- 
David Marchand
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help