On Mon, Feb 02, 2015 at 11:39:18AM +0600, Yerden Zhumabekov wrote:
02.02.2015 9:31, Neil Horman пишет:
quoted
On Mon, Feb 02, 2015 at 09:07:45AM +0600, Yerden Zhumabekov wrote:
quoted
I think so, I've just successfully built it against latest snapshot with
RTE_TARGET
equal to 'x86_64-native-linuxapp-gcc'.
Please confirm that setting the machine type to default builds and runs properly.
If I understood you correctly, I set CONFIG_RTE_MACHINE="default" in the
config and the build was successful.
Confirmed, this worked for me too.
Looking at the patches, they look good. However, one thing I think we are missing
is a unit test to verify that all our CRC implementations give the same result.
That would be useful as a sanity check of the software fallback especially. The
existing hash tests, test the hash table implementation rather than the
mathematical argorithm used to compute the hash values.
Overall, though, software fallback for CRC is something well worthwhile having.
Series Acked-by: Bruce Richardson [off-list ref]
--
Sincerely,
Yerden Zhumabekov
State Technical Service
Astana, KZ
2015-02-19 15:21, Bruce Richardson:
Confirmed, this worked for me too.
Looking at the patches, they look good. However, one thing I think we are missing
is a unit test to verify that all our CRC implementations give the same result.
That would be useful as a sanity check of the software fallback especially. The
existing hash tests, test the hash table implementation rather than the
mathematical argorithm used to compute the hash values.
Overall, though, software fallback for CRC is something well worthwhile having.
Series Acked-by: Bruce Richardson [off-list ref]
Applied, thanks
Note: running doxygen compilation helped me to find and fix a small
mismatch (parameter alg was flag in comment).
23.02.2015 23:36, Thomas Monjalon пишет:
2015-02-19 15:21, Bruce Richardson:
quoted
Confirmed, this worked for me too.
Looking at the patches, they look good. However, one thing I think we are missing
is a unit test to verify that all our CRC implementations give the same result.
That would be useful as a sanity check of the software fallback especially. The
existing hash tests, test the hash table implementation rather than the
mathematical argorithm used to compute the hash values.
Overall, though, software fallback for CRC is something well worthwhile having.
Series Acked-by: Bruce Richardson [off-list ref]
Applied, thanks
Note: running doxygen compilation helped me to find and fix a small
mismatch (parameter alg was flag in comment).
Thanks, Bruce, Thomas.
As for yielding the same hash value, I made a test which runs every
CRC32 implementation across a number of randomly generated data sets.
Results are equal on my trial run.
I can post a patch for test_hash.c a bit later if this kind of check
suffices.
--
Sincerely,
Yerden Zhumabekov
State Technical Service
Astana, KZ