On 30-08-24, 20:11, Krzysztof Kozlowski wrote:

On 30/08/2024 11:41, Liao Yuanhong wrote:

quoted

The devm_clk_get_enabled() helpers:
    - call devm_clk_get()
    - call clk_prepare_enable() and register what is needed in order to
     call clk_disable_unprepare() when needed, as a managed resource.

This simplifies the code and avoids the calls to clk_disable_unprepare().
---
v2:remove inappropriate modifications, configure COMPILE_TEST for easy
testing, add devm_clk_getprepaed() for imx sdma device.
---

Vinod,

Since ~2 weeks there is tremendous amount of trivial patches coming from
vivo.com. I identified at least 6 buggy, where the contributor did not
understand the code. Not sure about intention, but I advise extra
carefulness
when dealing with these "trivial" improvements.

Agree, these are introducing bugs as well..

Vivo folks, please channel your energies into fixing some real problems,
contributing support for your vivo phones including DT, drivers and
running mainline on them...

That would be better use of your and our time :-)

BR
-- 
~Vinod