Thread (2 messages) 2 messages, 2 authors, 2022-06-04

[PATCH v2] dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate

From: Miaoqian Lin <hidden>
Date: 2022-06-01 10:56:05
Also in: lkml
Subsystem: dma generic offload engine subsystem, texas instruments dma drivers, the rest · Maintainers: Vinod Koul, Peter Ujfalusi, Linus Torvalds

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not needed anymore.

Add missing of_node_put() in to fix this.

Fixes: ec9bfa1e1a79 ("dmaengine: ti-dma-crossbar: dra7: Use bitops instead of idr")
Signed-off-by: Miaoqian Lin <redacted>
---
- split v1 into two patches.
v1 link: https://lore.kernel.org/r/20220512051815.11946-1-linmq006@gmail.com (local)
---
 drivers/dma/ti/dma-crossbar.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/dma/ti/dma-crossbar.c b/drivers/dma/ti/dma-crossbar.c
index 71d24fc07c00..e34cfb50d241 100644
--- a/drivers/dma/ti/dma-crossbar.c
+++ b/drivers/dma/ti/dma-crossbar.c
@@ -268,6 +268,7 @@ static void *ti_dra7_xbar_route_allocate(struct of_phandle_args *dma_spec,
 		mutex_unlock(&xbar->mutex);
 		dev_err(&pdev->dev, "Run out of free DMA requests\n");
 		kfree(map);
+		of_node_put(dma_spec->np);
 		return ERR_PTR(-ENOMEM);
 	}
 	set_bit(map->xbar_out, xbar->dma_inuse);
-- 
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help