Thread (7 messages) 7 messages, 3 authors, 2018-05-17

dmaengine: qcom: bam_dma: fix some doc warnings.

From: Srinivas Kandagatla <hidden>
Date: 2018-05-17 10:53:43
Also in: linux-arm-kernel, linux-arm-msm, lkml

On 17/05/18 11:50, Vinod Koul wrote:
On 17-05-18, 10:59, Srinivas Kandagatla wrote:
quoted
diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
index 4a828c18099a..a05fff8a1447 100644
--- a/drivers/dma/qcom/bam_dma.c
+++ b/drivers/dma/qcom/bam_dma.c
@@ -451,7 +451,7 @@ static void bam_reset_channel(struct bam_chan *bchan)
  /**
   * bam_chan_init_hw - Initialize channel hardware
   * @bchan: bam channel
- *
+ * @dir: DMA transfer direction
Do you want to add an empty line here?
TBH, Am not 100% sure it it adds any value.

Most of the function docs in the file have this same issue.. :-)

let me know if you still want an empty line, I can respin.

--srini
quoted
   * This function resets and initializes the BAM channel
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help