[cip-dev][isar-cip-core][PATCH] swupdate-config: Remove runtime dependency efibootguard-dev

From: Quirin Gylstorff <redacted>

efibootguard-dev is only a build time dependency and
not an runtime dependency.

Signed-off-by: Quirin Gylstorff <redacted>
---
 classes/swupdate-config.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/classes/swupdate-config.bbclass b/classes/swupdate-config.bbclass
index dfa3579..e4879c7 100644
--- a/classes/swupdate-config.bbclass
+++ b/classes/swupdate-config.bbclass

@@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua"
 
 KFEATURE_efibootguard = ""
 KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev"
-KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev"
+KFEATURE_efibootguard[DEBIAN_DEPENDS] = ""
 KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev"
 KFEATURE_efibootguard[KCONFIG_SNIPPETS] = "file://swupdate_defconfig_efibootguard.snippet"
 

-- 
2.20.1

On 09.08.21 12:29, Q. Gylstorff wrote:

-dev makes no sense, but don't we have any dep on libs? Or are they
statically linked?

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

On 8/9/21 2:54 PM, Jan Kiszka wrote:

On 09.08.21 12:29, Q. Gylstorff wrote:

quoted

From: Quirin Gylstorff <redacted>

efibootguard-dev is only a build time dependency and
not an runtime dependency.

Signed-off-by: Quirin Gylstorff <redacted>
---
  classes/swupdate-config.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/classes/swupdate-config.bbclass b/classes/swupdate-config.bbclass
index dfa3579..e4879c7 100644
--- a/classes/swupdate-config.bbclass
+++ b/classes/swupdate-config.bbclass

@@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua"
  
  KFEATURE_efibootguard = ""
  KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev"
-KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev"
+KFEATURE_efibootguard[DEBIAN_DEPENDS] = ""
  KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev"
  KFEATURE_efibootguard[KCONFIG_SNIPPETS] = "file://swupdate_defconfig_efibootguard.snippet"
  

-dev makes no sense, but don't we have any dep on libs? Or are they
statically linked?

It is statically linked - efibootguard-dev contains only libebgenv.a.

Quirin

Jan

On 09.08.21 15:49, Gylstorff Quirin wrote:

On 8/9/21 2:54 PM, Jan Kiszka wrote:

quoted

On 09.08.21 12:29, Q. Gylstorff wrote:

quoted

From: Quirin Gylstorff <redacted>

efibootguard-dev is only a build time dependency and
not an runtime dependency.

Signed-off-by: Quirin Gylstorff <redacted>
---
  classes/swupdate-config.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/classes/swupdate-config.bbclass

b/classes/swupdate-config.bbclass
index dfa3579..e4879c7 100644

--- a/classes/swupdate-config.bbclass
+++ b/classes/swupdate-config.bbclass

@@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua"

    KFEATURE_efibootguard = ""
  KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev"
-KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev"
+KFEATURE_efibootguard[DEBIAN_DEPENDS] = ""
  KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev"
  KFEATURE_efibootguard[KCONFIG_SNIPPETS] =
"file://swupdate_defconfig_efibootguard.snippet"
 

-dev makes no sense, but don't we have any dep on libs? Or are they
statically linked?

It is statically linked - efibootguard-dev contains only libebgenv.a.

Ah, yeah, part the SWUpdate's problems...

Thanks, applied.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

quoted

quoted

quoted

efibootguard-dev is only a build time dependency and
not an runtime dependency.

Signed-off-by: Quirin Gylstorff <redacted>
---
  classes/swupdate-config.bbclass | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/classes/swupdate-config.bbclass

b/classes/swupdate-config.bbclass
index dfa3579..e4879c7 100644

--- a/classes/swupdate-config.bbclass
+++ b/classes/swupdate-config.bbclass

@@ -38,7 +38,7 @@ KFEATURE_DEPS[luahandler] = "lua"

    KFEATURE_efibootguard = ""
  KFEATURE_efibootguard[BUILD_DEB_DEPENDS] = "efibootguard-dev"
-KFEATURE_efibootguard[DEBIAN_DEPENDS] = "efibootguard-dev"
+KFEATURE_efibootguard[DEBIAN_DEPENDS] = ""
  KFEATURE_efibootguard[DEPENDS] = "efibootguard-dev"
  KFEATURE_efibootguard[KCONFIG_SNIPPETS] =
"file://swupdate_defconfig_efibootguard.snippet"
 

-dev makes no sense, but don't we have any dep on libs? Or are they
statically linked?

It is statically linked - efibootguard-dev contains only libebgenv.a.

Ah, yeah, part the SWUpdate's problems...

Well, meanwhile, this pattern has been deprecated in favor of
using https://github.com/sbabic/libubootenv
I guess it's about time for EFI Boot Guard to catch up..


Kind regards,
   Christian

-- 
Dr. Christian Storm
Siemens AG, Technology, T RDA IOT SES-DE
Otto-Hahn-Ring 6, 81739 München, Germany