[PATCH v7 03/10] memcg: enable accounting for file lock caches

Subsystems: file locking (flock() and fcntl()/lockf()), filesystems (vfs and infrastructure), the rest

STALE1889d

2 messages, 2 authors, 2021-07-27 · open the first message on its own page

[PATCH v7 03/10] memcg: enable accounting for file lock caches

From: Vasily Averin <hidden>
Date: 2021-07-27 05:34:21

User can create file locks for each open file and force kernel
to allocate small but long-living objects per each open file.

It makes sense to account for these objects to limit the host's memory
consumption from inside the memcg-limited container.

Signed-off-by: Vasily Averin <redacted>
---
 fs/locks.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 74b2a1d..1bc7ede 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -3056,10 +3056,12 @@ static int __init filelock_init(void)
 	int i;
 
 	flctx_cache = kmem_cache_create("file_lock_ctx",
-			sizeof(struct file_lock_context), 0, SLAB_PANIC, NULL);
+			sizeof(struct file_lock_context), 0,
+			SLAB_PANIC | SLAB_ACCOUNT, NULL);
 
 	filelock_cache = kmem_cache_create("file_lock_cache",
-			sizeof(struct file_lock), 0, SLAB_PANIC, NULL);
+			sizeof(struct file_lock), 0,
+			SLAB_PANIC | SLAB_ACCOUNT, NULL);
 
 	for_each_possible_cpu(i) {
 		struct file_lock_list_struct *fll = per_cpu_ptr(&file_lock_list, i);
-- 
1.8.3.1

Re: [PATCH v7 03/10] memcg: enable accounting for file lock caches

From: Shakeel Butt <hidden>
Date: 2021-07-27 21:41:39

On Mon, Jul 26, 2021 at 10:33 PM Vasily Averin [off-list ref] wrote:
User can create file locks for each open file and force kernel
to allocate small but long-living objects per each open file.

It makes sense to account for these objects to limit the host's memory
consumption from inside the memcg-limited container.

Signed-off-by: Vasily Averin <redacted>
Reviewed-by: Shakeel Butt <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help