Thread (161 messages) 161 messages, 7 authors, 2013-07-25

Re: [PATCH for 3.2.34] memcg: do not trigger OOM from add_to_page_cache_locked

From: Michal Hocko <hidden>
Date: 2012-12-17 19:55:26
Also in: linux-mm, lkml

Possibly related (same subject, not in this thread)

On Mon 17-12-12 19:23:01, azurIt wrote:
quoted
[Ohh, I am really an idiot. I screwed the first patch]
-       bool oom = true;
+       bool oom = !(gfp_mask | GFP_MEMCG_NO_OOM);

Which obviously doesn't work. It should read !(gfp_mask &GFP_MEMCG_NO_OOM).
 No idea how I could have missed that. I am really sorry about that.

:D no problem :) so, now it should really work as expected and
completely fix my original problem?
It should mitigate the problem. The real fix shouldn't be that specific
(as per discussion in other thread). The chance this will get upstream
is not big and that means that it will not get to the stable tree
either.
is it safe to apply it on 3.2.35?
I didn't check what are the differences but I do not think there is
anything to conflict with it.
Thank you very much!
HTH

-- 
Michal Hocko
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help