On 05/29/2012 06:20 PM, Christoph Lameter wrote:

On Tue, 29 May 2012, Christoph Lameter wrote:

quoted

quoted

  	* unlikely to succeed so close to the limit, and we fall back
  	 * to regular pages anyway in case of failure.
  	 */
-	if (nr_pages == 1&&  ret)
+	if (nr_pages<= (PAGE_SIZE<<  PAGE_ALLOC_COSTLY_ORDER)&&  ret) {

Should this not be

	 nr_pages<= 1<<  PAGE_ALLOC_COSTLY_ORDER

I myself believe you are right.

Not sure if Suleiman had anything in mind that we're not seeing when he 
wrote this code?