[Buildroot] [PATCH 1/1] package/rdma-core: needs NPTL

Subsystems: the rest

2 messages, 2 authors, 2023-03-10 · open the first message on its own page

[Buildroot] [PATCH 1/1] package/rdma-core: needs NPTL

From: Fabrice Fontaine <hidden>
Date: 2023-02-21 13:06:03

rdma-core unconditionally uses pthread_spin_lock since its addition in
commit ea47e177f093d7378e8e8e1f50d6f4e3fce0a088 resulting in the
following build failure:

/home/autobuild/autobuild/instance-9/output-1/host/lib/gcc/sh4-buildroot-linux-uclibc/12.2.0/../../../../sh4-buildroot-linux-uclibc/bin/ld: CMakeFiles/hfi1verbs-rdmav34.dir/verbs.c.o: in function `post_recv':
verbs.c:(.text+0xc4): undefined reference to `pthread_spin_lock'

Fixes:
 - http://autobuild.buildroot.org/results/a943e03b79c4cc328b7712046ecff09706045f81

Signed-off-by: Fabrice Fontaine <redacted>
---
 package/rdma-core/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/rdma-core/Config.in b/package/rdma-core/Config.in
index 59f5ef63ae..3360e6873d 100644
--- a/package/rdma-core/Config.in
+++ b/package/rdma-core/Config.in
@@ -4,7 +4,7 @@ config BR2_PACKAGE_RDMA_CORE
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4  # iproute2
 	depends on !BR2_STATIC_LIBS # dlopen()
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	select BR2_PACKAGE_IPROUTE2  # runtime
 	select BR2_PACKAGE_LIBNL
 	help
@@ -13,8 +13,8 @@ config BR2_PACKAGE_RDMA_CORE
 
 	  https://github.com/linux-rdma/rdma-core
 
-comment "rdma-core needs a toolchain w/ headers >= 3.4, threads, dynamic library"
+comment "rdma-core needs a toolchain w/ headers >= 3.4, NPTL, dynamic library"
 	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4 \
-		|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+		|| !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
-- 
2.39.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/rdma-core: needs NPTL

From: Arnout Vandecappelle <hidden>
Date: 2023-03-10 21:00:35


On 21/02/2023 14:05, Fabrice Fontaine wrote:
rdma-core unconditionally uses pthread_spin_lock since its addition in
commit ea47e177f093d7378e8e8e1f50d6f4e3fce0a088 resulting in the
following build failure:

/home/autobuild/autobuild/instance-9/output-1/host/lib/gcc/sh4-buildroot-linux-uclibc/12.2.0/../../../../sh4-buildroot-linux-uclibc/bin/ld: CMakeFiles/hfi1verbs-rdmav34.dir/verbs.c.o: in function `post_recv':
verbs.c:(.text+0xc4): undefined reference to `pthread_spin_lock'

Fixes:
  - http://autobuild.buildroot.org/results/a943e03b79c4cc328b7712046ecff09706045f81

Signed-off-by: Fabrice Fontaine <redacted>
 Applied to master, thanks.

 Regards,
 Arnout
quoted hunk
---
  package/rdma-core/Config.in | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/rdma-core/Config.in b/package/rdma-core/Config.in
index 59f5ef63ae..3360e6873d 100644
--- a/package/rdma-core/Config.in
+++ b/package/rdma-core/Config.in
@@ -4,7 +4,7 @@ config BR2_PACKAGE_RDMA_CORE
  	depends on BR2_TOOLCHAIN_HAS_SYNC_4
  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4  # iproute2
  	depends on !BR2_STATIC_LIBS # dlopen()
-	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
  	select BR2_PACKAGE_IPROUTE2  # runtime
  	select BR2_PACKAGE_LIBNL
  	help
@@ -13,8 +13,8 @@ config BR2_PACKAGE_RDMA_CORE
  
  	  https://github.com/linux-rdma/rdma-core
  
-comment "rdma-core needs a toolchain w/ headers >= 3.4, threads, dynamic library"
+comment "rdma-core needs a toolchain w/ headers >= 3.4, NPTL, dynamic library"
  	depends on BR2_USE_MMU
  	depends on BR2_TOOLCHAIN_HAS_SYNC_4
  	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4 \
-		|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+		|| !BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help