[Buildroot] [git commit] package/cups-pk-helper: fix dependencies

From: Yann E. MORIN <hidden>
Date: 2021-12-18 21:43:01
Subsystem: the rest · Maintainer: Linus Torvalds

commit: https://git.buildroot.net/buildroot/commit/?id=ff58dc6c35ac9e128c676780d7cd333abf4cd446
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master

Fix dependencies which are wrong since the addition of the package in
commit e13c9ccf436cf13b53bec6933e5be4bb071cfad9 resulting in the
following build failure:

Makefile:587: *** duktape is in the dependency chain of polkit that has added it to its _DEPENDENCIES variable without selecting it or depending on it from Config.in.  Stop.

Fixes:
 - http://autobuild.buildroot.org/results/706a09b245880e99109a4cc99faffe83f458afc4

Signed-off-by: Fabrice Fontaine <redacted>
Signed-off-by: Yann E. MORIN <redacted>
---
 package/cups-pk-helper/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/cups-pk-helper/Config.in b/package/cups-pk-helper/Config.in
index 63a0d3acd8..113f433795 100644
--- a/package/cups-pk-helper/Config.in
+++ b/package/cups-pk-helper/Config.in
@@ -1,8 +1,10 @@
 config BR2_PACKAGE_CUPS_PK_HELPER
 	bool "cups-pk-helper"
+	depends on BR2_USE_MMU
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # polkit -> c++17
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2, polkit
 	depends on BR2_USE_WCHAR # libglib2
+	depends on !BR2_STATIC_LIBS # polkit -> duktape
 	depends on BR2_PACKAGE_CUPS
 	select BR2_PACKAGE_POLKIT
 	help
@@ -11,7 +13,7 @@ config BR2_PACKAGE_CUPS_PK_HELPER
 
 	  https://wiki.freedesktop.org/www/Software/cups-pk-helper/
 
-comment "cups-pk-helper support needs a toolchain with threads, wchar, gcc >= 7"
+comment "cups-pk-helper support needs a toolchain with threads, wchar, dynamic library, gcc >= 7"
 	depends on BR2_USE_MMU
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || \
-		!BR2_TOOLCHAIN_HAS_THREADS
+		!BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help