[Buildroot] [git commit] package/libcamera: add arch dependency to hardware pipelines
From: Yann E. MORIN <hidden>
Date: 2021-10-16 07:23:29
Subsystem:
the rest · Maintainer:
Linus Torvalds
commit: https://git.buildroot.net/buildroot/commit/?id=6b1f3de47d1c8822ddbeaf9ea8512a5f00148ad7 branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master The hardware related pipelines are obviously not available on other architectures. As suggested by upstream [0], add a dependency on arm or aarch64 for RaspberryPi pipeline, to avoid the following build failure with a powerpc64 toolchain since commit c09f126f5703 (package/libcamera: bump to version e355ca0087cd93ef80f74c61018e9e9228a93313): In file included from ../include/libcamera/base/log.h:10, from ../src/ipa/raspberrypi/raspberrypi.cpp:18: ../src/ipa/raspberrypi/raspberrypi.cpp:64:53: in 'constexpr' expansion of 'std::chrono::operator/<long double, std::ratio<1>, double>(std::literals::chrono_literals::operator""s(1.0e+0l), 3.0e+1)' /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/powerpc64-buildroot-linux-gnu/include/c++/9.3.0/chrono:502:32: error: '(1.0e+0l / 3.0e+1)' is not a constant expression 502 | return __cd(__cd(__d).count() / __s); ../src/ipa/raspberrypi/raspberrypi.cpp:73:56: in 'constexpr' expansion of 'std::chrono::operator/<long double, std::ratio<1>, double>(std::literals::chrono_literals::operator""s(1.0e+0l), 6.0e+1)' /home/buildroot/autobuild/instance-2/output-1/host/opt/ext-toolchain/powerpc64-buildroot-linux-gnu/include/c++/9.3.0/chrono:502:32: error: '(1.0e+0l / 6.0e+1)' is not a constant expression Fixes: - http://autobuild.buildroot.org/results/49caebe7ef7e3d63de49e78d5d6839dd0aedf10c Additionally, as Kieran puts it: I'd go further and filter the IPU3 on only x86 for instance, and the RKISP on (arm||aarch64). So be it. [0] https://lists.libcamera.org/pipermail/libcamera-devel/2021-October/025796.html: Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Suggested-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Signed-off-by: Fabrice Fontaine <redacted> [yann.morin.1998@free.fr: abide by Kieran's wish] Signed-off-by: Yann E. MORIN <redacted> --- package/libcamera/Config.in | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/package/libcamera/Config.in b/package/libcamera/Config.in
index 92c17df849..b7f0e5b05d 100644
--- a/package/libcamera/Config.in
+++ b/package/libcamera/Config.in@@ -34,12 +34,14 @@ config BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE config BR2_PACKAGE_LIBCAMERA_PIPELINE_IPU3 bool "ipu3 pipeline" + depends on BR2_i386 || BR2_x86_64 select BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE help Pipeline for Intel IPU3. config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI bool "raspberrypi pipeline" + depends on BR2_arm || BR2_aarch64 depends on BR2_USE_WCHAR # boost (already enforced for gnutls) select BR2_PACKAGE_BOOST select BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE
@@ -48,6 +50,7 @@ config BR2_PACKAGE_LIBCAMERA_PIPELINE_RASPBERRYPI config BR2_PACKAGE_LIBCAMERA_PIPELINE_RKISP1 bool "rkisp1 pipeline" + depends on BR2_arm || BR2_aarch64 select BR2_PACKAGE_LIBCAMERA_HAS_PIPELINE help Pipeline for Rockchip ISP1.
_______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot