This reverts commit 46b8fb7500ecca65a79507318fd3052208559c09 indeed if
libressl is selected as the openssl provider, the BR2_PACKAGE_OPENSSL
conditition will always be used and the BR2_PACKAGE_LIBRESSL condition
will never be triggered. Moreover, libressl provides a pkg-config file.
Signed-off-by: Fabrice Fontaine <redacted>
---
package/libshout/libshout.mk | 3 ---
1 file changed, 3 deletions(-)
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Date: 2021-08-19 20:51:32
On Wed, 18 Aug 2021 00:15:30 +0200
Fabrice Fontaine [off-list ref] wrote:
This reverts commit 46b8fb7500ecca65a79507318fd3052208559c09 indeed if
libressl is selected as the openssl provider, the BR2_PACKAGE_OPENSSL
conditition will always be used and the BR2_PACKAGE_LIBRESSL condition
will never be triggered. Moreover, libressl provides a pkg-config file.
Signed-off-by: Fabrice Fontaine <redacted>
---
package/libshout/libshout.mk | 3 ---
1 file changed, 3 deletions(-)
I've applied to master, because you're right, what
46b8fb7500ecca65a79507318fd3052208559c09 has added is a no-op, because
BR2_PACKAGE_LIBRESSL cannot be 'y' without BR2_PACKAGE_OPENSSL also
being 'y'.
However, could you look at the autobuilder issue that
46b8fb7500ecca65a79507318fd3052208559c09 was intended to fix, and see
what is the proper fix for it ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Le jeu. 19 août 2021 à 22:51, Thomas Petazzoni
[off-list ref] a écrit :
On Wed, 18 Aug 2021 00:15:30 +0200
Fabrice Fontaine [off-list ref] wrote:
quoted
This reverts commit 46b8fb7500ecca65a79507318fd3052208559c09 indeed if
libressl is selected as the openssl provider, the BR2_PACKAGE_OPENSSL
conditition will always be used and the BR2_PACKAGE_LIBRESSL condition
will never be triggered. Moreover, libressl provides a pkg-config file.
Signed-off-by: Fabrice Fontaine <redacted>
---
package/libshout/libshout.mk | 3 ---
1 file changed, 3 deletions(-)
I've applied to master, because you're right, what
46b8fb7500ecca65a79507318fd3052208559c09 has added is a no-op, because
BR2_PACKAGE_LIBRESSL cannot be 'y' without BR2_PACKAGE_OPENSSL also
being 'y'.
However, could you look at the autobuilder issue that
46b8fb7500ecca65a79507318fd3052208559c09 was intended to fix, and see
what is the proper fix for it ?
The autobuilder link given in the commit message returns 404.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
From: Yann E. MORIN <hidden> Date: 2021-08-19 21:10:15
Fabrice, All,
On 2021-08-19 22:57 +0200, Fabrice Fontaine spake thusly:
Le jeu. 19 août 2021 à 22:51, Thomas Petazzoni
[off-list ref] a écrit :
quoted
On Wed, 18 Aug 2021 00:15:30 +0200
Fabrice Fontaine [off-list ref] wrote:
quoted
This reverts commit 46b8fb7500ecca65a79507318fd3052208559c09 indeed if
libressl is selected as the openssl provider, the BR2_PACKAGE_OPENSSL
conditition will always be used and the BR2_PACKAGE_LIBRESSL condition
will never be triggered. Moreover, libressl provides a pkg-config file.
Signed-off-by: Fabrice Fontaine <redacted>
---
package/libshout/libshout.mk | 3 ---
1 file changed, 3 deletions(-)
I've applied to master, because you're right, what
46b8fb7500ecca65a79507318fd3052208559c09 has added is a no-op, because
BR2_PACKAGE_LIBRESSL cannot be 'y' without BR2_PACKAGE_OPENSSL also
being 'y'.
However, could you look at the autobuilder issue that
46b8fb7500ecca65a79507318fd3052208559c09 was intended to fix, and see
what is the proper fix for it ?
The autobuilder link given in the commit message returns 404.
Ah, that's from before we lost the DB in an HDD crash...
Regards,
Yann E. MORIN.
quoted
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Date: 2021-08-19 21:13:03
On Thu, 19 Aug 2021 22:57:08 +0200
Fabrice Fontaine [off-list ref] wrote:
quoted
However, could you look at the autobuilder issue that
46b8fb7500ecca65a79507318fd3052208559c09 was intended to fix, and see
what is the proper fix for it ?
The autobuilder link given in the commit message returns 404.
Aah, but it is a very old commit and build failure from 2017. Indeed,
we have lost such old build results. But back then, I believe openssl
and libressl were not "combined" as a virtual package, so the two
options were really mutually exclusive.
I assume you did a build of libshout with libressl, and noted that it
was now correct thanks to libressl providing .pc files. Correct?
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Le jeu. 19 août 2021 à 23:12, Thomas Petazzoni
[off-list ref] a écrit :
On Thu, 19 Aug 2021 22:57:08 +0200
Fabrice Fontaine [off-list ref] wrote:
quoted
quoted
However, could you look at the autobuilder issue that
46b8fb7500ecca65a79507318fd3052208559c09 was intended to fix, and see
what is the proper fix for it ?
The autobuilder link given in the commit message returns 404.
Aah, but it is a very old commit and build failure from 2017. Indeed,
we have lost such old build results. But back then, I believe openssl
and libressl were not "combined" as a virtual package, so the two
options were really mutually exclusive.
I assume you did a build of libshout with libressl, and noted that it
was now correct thanks to libressl providing .pc files. Correct?
Yes, it builds fine because libressl provides openssl.pc but it wasn't
a surprise as I basically removed dead code.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
> This reverts commit 46b8fb7500ecca65a79507318fd3052208559c09 indeed if
> libressl is selected as the openssl provider, the BR2_PACKAGE_OPENSSL
> conditition will always be used and the BR2_PACKAGE_LIBRESSL condition
> will never be triggered. Moreover, libressl provides a pkg-config file.
> Signed-off-by: Fabrice Fontaine [off-list ref]
Committed to 2021.02.x and 2021.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot