Hello everyone,
I received excellent help from y_morin and vfazio in the buildroot IRC, as such I would like to share the results.
MDSPlus is a networked database system for nuclear fusion and particle accelerator research labs (see www.mdsplus.org<http://www.mdsplus.org>). Its focus is on carefully and clearly organizing large bursts of data by time.
Buildroot now supports binaries built to use MDSPlus libraries through the enclosed attachments.
Thanks for your attention,
~A
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200117/27eb87ee/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Config.in
Type: application/octet-stream
Size: 625 bytes
Desc: Config.in
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200117/27eb87ee/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-mdsplus-remove-assert-fail.patch
Type: application/octet-stream
Size: 1407 bytes
Desc: 0002-mdsplus-remove-assert-fail.patch
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200117/27eb87ee/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-mds-disable-testing.patch
Type: application/octet-stream
Size: 628 bytes
Desc: 0001-mds-disable-testing.patch
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200117/27eb87ee/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mdsplus.mk
Type: application/octet-stream
Size: 579 bytes
Desc: mdsplus.mk
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20200117/27eb87ee/attachment-0003.obj>
Hi Andrew,
On 17/01/2020 22:18, Andrew Alexander wrote:
Hello everyone,
I received excellent help from y_morin and vfazio in the buildroot IRC, as such I would like to share the results.
Thank you for your contribution!
MDSPlus is a networked database system for nuclear fusion and particle accelerator research labs (see www.mdsplus.org<http://www.mdsplus.org>). Its focus is on carefully and clearly organizing large bursts of data by time.
Buildroot now supports binaries built to use MDSPlus libraries through the enclosed attachments.
However, please submit it as a patch to the Buildroot git tree, as explained in
the documentation [1]. In particular, make sure the commit message carries a
Signed-off-by tag, which is your contributor agreement.
Also a few things are missing in the files you attached:
- Each patch should have a description (like a commit message) which also
includes your Signed-off-by. A Signed-off-by is needed again because the patch
will have to follow the license of the upstream project, not Buildroot's GPL-2.0
license.
- Since the upstream project is based on git, the patches should be
git-formatted (i.e., generated with `git format-patch -N`).
- There should be a hash file, which contains a hash of the tarball and of each
license file.
- The tarball is an automatically generated tarball, so it should use the github
helper instead of a direct URL.
- In Config.in, BR2_PACKAGE_LIBXML2 should be select'ed instead of depended on.
- The BR2_PACKAGE_MDSPLUS_SERVER option is not used.
- There shouldn't be a hardcoded path to a microblaze toolchain.
- The license is GPL-2.0, not GPLv2 (SPDX format).
- You should add it to package/Config.in or it won't be visible in the menu.
- You should add yourself to the DEVELOPERS file.
Thanks!
Regards,
Arnout
[1] https://buildroot.org/downloads/manual/manual.html#submitting-patches
Thanks for your attention,
~A
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Andrew,
On 1/21/20 3:01 PM, Arnout Vandecappelle wrote:
Hi Andrew,
On 17/01/2020 22:18, Andrew Alexander wrote:
quoted
Hello everyone,
I received excellent help from y_morin and vfazio in the buildroot IRC, as such I would like to share the results.
Thank you for your contribution!
quoted
MDSPlus is a networked database system for nuclear fusion and particle accelerator research labs (see www.mdsplus.org<http://www.mdsplus.org>). Its focus is on carefully and clearly organizing large bursts of data by time.
Buildroot now supports binaries built to use MDSPlus libraries through the enclosed attachments.
However, please submit it as a patch to the Buildroot git tree, as explained in
the documentation [1]. In particular, make sure the commit message carries a
Signed-off-by tag, which is your contributor agreement.
Also a few things are missing in the files you attached:
- Each patch should have a description (like a commit message) which also
includes your Signed-off-by. A Signed-off-by is needed again because the patch
will have to follow the license of the upstream project, not Buildroot's GPL-2.0
license.
- Since the upstream project is based on git, the patches should be
git-formatted (i.e., generated with `git format-patch -N`).
- There should be a hash file, which contains a hash of the tarball and of each
license file.
- The tarball is an automatically generated tarball, so it should use the github
helper instead of a direct URL.
- In Config.in, BR2_PACKAGE_LIBXML2 should be select'ed instead of depended on.
- The BR2_PACKAGE_MDSPLUS_SERVER option is not used.
- There shouldn't be a hardcoded path to a microblaze toolchain.
- The license is GPL-2.0, not GPLv2 (SPDX format).
- You should add it to package/Config.in or it won't be visible in the menu.
- You should add yourself to the DEVELOPERS file.
Thanks!
Regards,
Arnout
I'm going to try to find some time to do some additional review
tomorrow. I had started a bit today but forgot that a fortran compiler
was required (we'll want to adjust the dependencies to account for that)
[1] https://buildroot.org/downloads/manual/manual.html#submitting-patches
quoted
Thanks for your attention,
~A
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
--
Vincent Fazio
Embedded Software Engineer - Linux
Extreme Engineering Solutions, Inc
http://www.xes-inc.com