[Buildroot] [PATCH 1/2] package/sysdig: reorder select/depends

Subsystems: the rest

3 messages, 2 authors, 2016-01-01 · open the first message on its own page

[Buildroot] [PATCH 1/2] package/sysdig: reorder select/depends

From: Romain Naour <hidden>
Date: 2016-01-01 20:02:21

From [1]:
"Even though the ordering has absolutely no consequences in Kconfig, it
is not logical (when reading). It is more logical and far easier to
understand when depends come first, followed by the selects."

Also, the Config.in exemple in the manual suggest to use this coding
style [2].

[1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
[2] http://buildroot.uclibc.org/downloads/manual/manual.html#writing-rules-config-in

Signed-off-by: Romain Naour <redacted>
---
 package/sysdig/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
index dc71d5f..151e75d 100644
--- a/package/sysdig/Config.in
+++ b/package/sysdig/Config.in

@@ -1,12 +1,12 @@
 config BR2_PACKAGE_SYSDIG
 	bool "sysdig"
-	select BR2_PACKAGE_ZLIB
-	select BR2_PACKAGE_LUAJIT
-	select BR2_PACKAGE_JSONCPP
 	depends on BR2_LINUX_KERNEL
 	depends on BR2_INSTALL_LIBSTDCPP # libjson
 	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
 	depends on !BR2_STATIC_LIBS # luajit
+	select BR2_PACKAGE_ZLIB
+	select BR2_PACKAGE_LUAJIT
+	select BR2_PACKAGE_JSONCPP
 	help
 	  Sysdig is open source, system-level exploration:
 	  capture system state and activity from a running Linux instance,

-- 
2.4.3

[Buildroot] [PATCH 2/2] package:sysdig: propagate dependencies from jsoncpp

From: Romain Naour <hidden>
Date: 2016-01-01 20:02:22

sysdig select jsoncpp which needs a gcc compiler >= 4.7

Signed-off-by: Romain Naour <redacted>
---
 package/sysdig/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
index 151e75d..dfb9db5 100644
--- a/package/sysdig/Config.in
+++ b/package/sysdig/Config.in

@@ -3,6 +3,7 @@ config BR2_PACKAGE_SYSDIG
 	depends on BR2_LINUX_KERNEL
 	depends on BR2_INSTALL_LIBSTDCPP # libjson
 	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # jsoncpp
 	depends on !BR2_STATIC_LIBS # luajit
 	select BR2_PACKAGE_ZLIB
 	select BR2_PACKAGE_LUAJIT

@@ -16,6 +17,7 @@ config BR2_PACKAGE_SYSDIG
 
 	  http://sysdig.org
 
-comment "sysdig needs a toolchain w/ C++, dynamic library and a Linux kernel to be built"
-	depends on !BR2_LINUX_KERNEL || !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS
+comment "sysdig needs a toolchain w/ C++, gcc >= 4.7, dynamic library and a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL || !BR2_INSTALL_LIBSTDCPP \
+		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 || BR2_STATIC_LIBS
 	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS

-- 
2.4.3

[Buildroot] [PATCH 1/2] package/sysdig: reorder select/depends

From: Peter Korsgaard <peter@korsgaard.com>
Date: 2016-01-01 21:01:26

quoted
quoted
quoted
quoted
"Romain" == Romain Naour [off-list ref] writes:

 >> From [1]:
 > "Even though the ordering has absolutely no consequences in Kconfig, it
 > is not logical (when reading). It is more logical and far easier to
 > understand when depends come first, followed by the selects."

 > Also, the Config.in exemple in the manual suggest to use this coding
 > style [2].

Committed both, thanks.

-- 
Bye, Peter Korsgaard

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help