[Buildroot] [git commit] toolchain/external: ensure gcc version is known
From: Thomas Petazzoni <hidden>
Date: 2015-08-18 09:47:23
Subsystem:
the rest · Maintainer:
Linus Torvalds
From: Thomas Petazzoni <hidden>
Date: 2015-08-18 09:47:23
Subsystem:
the rest · Maintainer:
Linus Torvalds
commit: http://git.buildroot.net/buildroot/commit/?id=23fde76859ddcbc6415f61ddfdd4ee14453eb758 branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master Currently, when a preconfigured prebuilt toolchain forgets to specify its gcc version, the error message is a bit misleading, like: Incorrect selection of gcc version: expected .x, got 4.9.2 Add a an explicit check for the gcc version being set, that reports a better error message. Signed-off-by: "Yann E. MORIN" <redacted> Cc: Thomas Petazzoni <redacted> Signed-off-by: Thomas Petazzoni <redacted> --- toolchain/helpers.mk | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/toolchain/helpers.mk b/toolchain/helpers.mk
index 7c70d35..85a9407 100644
--- a/toolchain/helpers.mk
+++ b/toolchain/helpers.mk@@ -193,6 +193,10 @@ check_kernel_headers_version = \ # check_gcc_version = \ expected_version="$(strip $2)" ; \ + if [ -z "$${expected_version}" ]; then \ + printf "Internal error, gcc version unknown (no GCC_AT_LEAST_X_Y selected)\n"; \ + exit 1 ; \ + fi; \ real_version=`$(1) --version | sed -r -e '1!d; s/^[^)]+\) ([^[:space:]]+).*/\1/;'` ; \ if [[ ! "$${real_version}" =~ ^$${expected_version}\. ]] ; then \ printf "Incorrect selection of gcc version: expected %s.x, got %s\n" \