[Buildroot] svn commit: trunk/buildroot/toolchain/gcc

3 messages, 3 authors, 2007-09-03 · open the first message on its own page

[Buildroot] svn commit: trunk/buildroot/toolchain/gcc

From: ulf at uclibc.org <hidden>
Date: 2007-07-07 12:28:29

Author: ulf
Date: 2007-07-07 05:28:25 -0700 (Sat, 07 Jul 2007)
New Revision: 19020

Log:
Avoid stripping scripts

Modified:
   trunk/buildroot/toolchain/gcc/gcc-uclibc-4.x.mk


Changeset:
Modified: trunk/buildroot/toolchain/gcc/gcc-uclibc-4.x.mk
===================================================================
--- trunk/buildroot/toolchain/gcc/gcc-uclibc-4.x.mk	2007-07-07 11:06:08 UTC (rev 19019)
+++ trunk/buildroot/toolchain/gcc/gcc-uclibc-4.x.mk	2007-07-07 12:28:25 UTC (rev 19020)
@@ -247,17 +247,13 @@
 		mv "$(STAGING_DIR)/lib64/"* "$(STAGING_DIR)/lib/" ; \
 		rmdir "$(STAGING_DIR)/lib64" ; \
 	fi
+	# Move gcc bug reporting script out of path of real executables
+	mv -f $(STAGING_DIR)/usr/bin/$(REAL_GNU_TARGET_NAME)-gccbug \
+		$(STAGING_DIR)/usr/bin/$(GNU_TARGET_NAME)-gccbug
 	# Strip the host binaries
 ifeq ($(GCC_STRIP_HOST_BINARIES),true)
-	if [ -e $(STAGING_DIR)/usr/bin/*-gccbug ] ; then \
-		mkdir -p "$(STAGING_DIR)/tmp" ; \
-		mv $(STAGING_DIR)/usr/bin/*-gccbug  $(STAGING_DIR)/tmp ; \
-		-strip --strip-all -R .note -R .comment $(STAGING_DIR)/usr/bin/* ; \
-		mv $(STAGING_DIR)/tmp/*-gccbug $(STAGING_DIR)/usr/bin ; \
-		rmdir "$(STAGING_DIR)/tmp" ; \
-	else \
-		-strip --strip-all -R .note -R .comment $(STAGING_DIR)/usr/bin/* ; \
-	fi
+	-strip --strip-all -R .note -R .comment $(STAGING_DIR)/usr/bin/$(REAL_GNU_TARGET_NAME)-*
+	-strip --strip-all -R .note -R .comment $(STAGING_DIR)/usr/bin/faked
 endif
 	# Make sure we have 'cc'.
 	if [ ! -e $(STAGING_DIR)/usr/bin/$(REAL_GNU_TARGET_NAME)-cc ] ; then \

[Buildroot] svn commit: trunk/buildroot/toolchain/gcc

From: Bernhard Fischer <hidden>
Date: 2007-09-01 18:43:00

On Sat, Jul 07, 2007 at 05:28:29AM -0700, ulf at uclibc.org wrote:
quoted hunk
Author: ulf
Date: 2007-07-07 05:28:25 -0700 (Sat, 07 Jul 2007)
New Revision: 19020

Log:
Avoid stripping scripts

Modified:
  trunk/buildroot/toolchain/gcc/gcc-uclibc-4.x.mk


Changeset:
Modified: trunk/buildroot/toolchain/gcc/gcc-uclibc-4.x.mk
===================================================================
--- trunk/buildroot/toolchain/gcc/gcc-uclibc-4.x.mk	2007-07-07 11:06:08 UTC (rev 19019)
+++ trunk/buildroot/toolchain/gcc/gcc-uclibc-4.x.mk	2007-07-07 12:28:25 UTC (rev 19020)
@@ -247,17 +247,13 @@
		mv "$(STAGING_DIR)/lib64/"* "$(STAGING_DIR)/lib/" ; \
		rmdir "$(STAGING_DIR)/lib64" ; \
	fi
+	# Move gcc bug reporting script out of path of real executables
+	mv -f $(STAGING_DIR)/usr/bin/$(REAL_GNU_TARGET_NAME)-gccbug \
+		$(STAGING_DIR)/usr/bin/$(GNU_TARGET_NAME)-gccbug
	# Strip the host binaries
ifeq ($(GCC_STRIP_HOST_BINARIES),true)
-	if [ -e $(STAGING_DIR)/usr/bin/*-gccbug ] ; then \
-		mkdir -p "$(STAGING_DIR)/tmp" ; \
-		mv $(STAGING_DIR)/usr/bin/*-gccbug  $(STAGING_DIR)/tmp ; \
-		-strip --strip-all -R .note -R .comment $(STAGING_DIR)/usr/bin/* ; \
-		mv $(STAGING_DIR)/tmp/*-gccbug $(STAGING_DIR)/usr/bin ; \
-		rmdir "$(STAGING_DIR)/tmp" ; \
-	else \
-		-strip --strip-all -R .note -R .comment $(STAGING_DIR)/usr/bin/* ; \
-	fi
+	-strip --strip-all -R .note -R .comment $(STAGING_DIR)/usr/bin/$(REAL_GNU_TARGET_NAME)-*
+	-strip --strip-all -R .note -R .comment $(STAGING_DIR)/usr/bin/faked
Ulf, please explain why you introduced this bug?
WTH is faked doing in gcc? I urge you to fix this..

[Buildroot] svn commit: trunk/buildroot/toolchain/gcc

From: Ulf Samuelsson <hidden>
Date: 2007-09-03 07:41:39

l?r 2007-09-01 klockan 20:43 +0200 skrev Bernhard Fischer:
On Sat, Jul 07, 2007 at 05:28:29AM -0700, ulf at uclibc.org wrote:
quoted
Author: ulf
Date: 2007-07-07 05:28:25 -0700 (Sat, 07 Jul 2007)
New Revision: 19020

Log:
Avoid stripping scripts

Modified:
  trunk/buildroot/toolchain/gcc/gcc-uclibc-4.x.mk


Changeset:
Modified: trunk/buildroot/toolchain/gcc/gcc-uclibc-4.x.mk
===================================================================
--- trunk/buildroot/toolchain/gcc/gcc-uclibc-4.x.mk	2007-07-07 11:06:08 UTC (rev 19019)
+++ trunk/buildroot/toolchain/gcc/gcc-uclibc-4.x.mk	2007-07-07 12:28:25 UTC (rev 19020)
@@ -247,17 +247,13 @@
		mv "$(STAGING_DIR)/lib64/"* "$(STAGING_DIR)/lib/" ; \
		rmdir "$(STAGING_DIR)/lib64" ; \
	fi
+	# Move gcc bug reporting script out of path of real executables
+	mv -f $(STAGING_DIR)/usr/bin/$(REAL_GNU_TARGET_NAME)-gccbug \
+		$(STAGING_DIR)/usr/bin/$(GNU_TARGET_NAME)-gccbug
	# Strip the host binaries
ifeq ($(GCC_STRIP_HOST_BINARIES),true)
-	if [ -e $(STAGING_DIR)/usr/bin/*-gccbug ] ; then \
-		mkdir -p "$(STAGING_DIR)/tmp" ; \
-		mv $(STAGING_DIR)/usr/bin/*-gccbug  $(STAGING_DIR)/tmp ; \
-		-strip --strip-all -R .note -R .comment $(STAGING_DIR)/usr/bin/* ; \
-		mv $(STAGING_DIR)/tmp/*-gccbug $(STAGING_DIR)/usr/bin ; \
-		rmdir "$(STAGING_DIR)/tmp" ; \
-	else \
-		-strip --strip-all -R .note -R .comment $(STAGING_DIR)/usr/bin/* ; \
-	fi
+	-strip --strip-all -R .note -R .comment $(STAGING_DIR)/usr/bin/$(REAL_GNU_TARGET_NAME)-*
+	-strip --strip-all -R .note -R .comment $(STAGING_DIR)/usr/bin/faked
Ulf, please explain why you introduced this bug?
WTH is faked doing in gcc? I urge you to fix this..
Previously it would strip  "$(STAGING_DIR)/usr/bin/*"
'*' would also strip faked (if present)

I "fixed" the gccbug stuff by renaming it,and then only stripped
$(REAL_GNU_TARGET_NAME)-*

To maintain compatability with the previous implementation.
I also stripped faked.

Your filter-out is better, so I removed the rename and removed the strip
of faked.


-- 
Best Regards,
Ulf Samuelsson
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help